runtime/vm/flow_graph_compiler_arm.cc - Issue 2780393005: Move the canonical empty context to the VM isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2780393005: Move the canonical empty context to the VM isolate. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_arm.cc

diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc

index 1b50fdff168c728fa59e2359e5b84ab20ba05d9a..a948896cb9313ed3e2e02c9b9ec230955c6bd782 100644

--- a/runtime/vm/flow_graph_compiler_arm.cc

+++ b/runtime/vm/flow_graph_compiler_arm.cc

@@ -1047,9 +1047,7 @@ void FlowGraphCompiler::CompileGraph() {

if (function.IsClosureFunction()) {

__ StoreToOffset(kWord, CTX, FP, (slot_base - i) * kWordSize);

} else {

- const Context& empty_context = Context::ZoneHandle(

- zone(), isolate()->object_store()->empty_context());

- __ LoadObject(R1, empty_context);

+ __ LoadObject(R1, Object::empty_context());

__ StoreToOffset(kWord, R1, FP, (slot_base - i) * kWordSize);

}

} else {

« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »