Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2780353005: Fix history navigations in PlzNavigate to use the proper load flags. (Closed)

Created:
3 years, 8 months ago by nasko
Modified:
3 years, 8 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, Charlie Reis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix history navigations in PlzNavigate to use the proper load flags. There is a difference in flags between the regular navigation path and PlzNavigate. This CL fixes the new path to have the same logic as the existing one. BUG=707282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2780353005 Cr-Commit-Position: refs/heads/master@{#461240} Committed: https://chromium.googlesource.com/chromium/src/+/7ee0fa238b36d1f1a12a240f2caf025559727ec4

Patch Set 1 #

Patch Set 2 : Fix test case and add test file. #

Total comments: 8

Patch Set 3 : Fixes based on review by csharrison@ #

Total comments: 2

Patch Set 4 : Add missing s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/navigation_controller/page_with_no_cache_header.html View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/navigation_controller/page_with_no_cache_header.html.mock-http-headers View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
nasko
Hey Charles, Can you review this CL for me? It fixes the issue you found. ...
3 years, 8 months ago (2017-03-31 19:55:44 UTC) #3
Charlie Harrison
Looks great! Have you verified this test fails without the fix? https://codereview.chromium.org/2780353005/diff/20001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): ...
3 years, 8 months ago (2017-03-31 19:59:28 UTC) #4
nasko
https://codereview.chromium.org/2780353005/diff/20001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2780353005/diff/20001/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode6820 content/browser/frame_host/navigation_controller_impl_browsertest.cc:6820: // header, stops the server, and goes back expecting ...
3 years, 8 months ago (2017-03-31 20:08:47 UTC) #5
nasko
On 2017/03/31 19:59:28, Charlie Harrison wrote: > Looks great! Have you verified this test fails ...
3 years, 8 months ago (2017-03-31 20:09:23 UTC) #6
Charlie Harrison
LGTM % small nit Nicely done! https://codereview.chromium.org/2780353005/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2780353005/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode6820 content/browser/frame_host/navigation_controller_impl_browsertest.cc:6820: // header, stops ...
3 years, 8 months ago (2017-03-31 20:12:13 UTC) #7
nasko
https://codereview.chromium.org/2780353005/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2780353005/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode6820 content/browser/frame_host/navigation_controller_impl_browsertest.cc:6820: // header, stops the server, and goes back expecting ...
3 years, 8 months ago (2017-03-31 20:15:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780353005/60001
3 years, 8 months ago (2017-03-31 20:16:29 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 21:55:40 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7ee0fa238b36d1f1a12a240f2caf...

Powered by Google App Engine
This is Rietveld 408576698