Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2780353004: Increase the range of WasmInstanteModuleMicroSeconds histograms. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
Reviewers:
bbudge, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Increase the range of WasmInstanteModuleMicroSeconds histograms. Looking at UMA results, we are geting a number of instantiations (4%) that are being lumped into the 1 second (plus) maximum entry. To get more visibility into the values in this bucket, this CL lift the maximun to 10 seconds. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2780353004 Cr-Commit-Position: refs/heads/master@{#44313} Committed: https://chromium.googlesource.com/v8/v8/+/9fc6398f72a77bb32b219b10c68ae6f67c501f09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/counters.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
kschimpf
Please review. Thanks.
3 years, 8 months ago (2017-03-30 22:08:10 UTC) #3
bbudge
lgtm
3 years, 8 months ago (2017-03-30 22:42:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780353004/1
3 years, 8 months ago (2017-03-31 15:21:22 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 15:22:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9fc6398f72a77bb32b219b10c68ae6f67c5...

Powered by Google App Engine
This is Rietveld 408576698