Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2780323002:
Sets is_reliable for CLD3 if below a minimum byte threshold of 50 bytes. (Closed)
DescriptionSets is_reliable for CLD3 if below a minimum byte threshold of 50 bytes.
BUG=706606
Review-Url: https://codereview.chromium.org/2780323002
Cr-Commit-Position: refs/heads/master@{#461560}
Committed: https://chromium.googlesource.com/chromium/src/+/88953d9c7663f797a6c92b8b764812d0e84ef8d9
Patch Set 1 #Patch Set 2 : Sets CLD3 minimum-reliable byte limit to 50 bytes based on experiments #
Total comments: 1
Patch Set 3 : Removes comments specific to Translate Extension #Messages
Total messages: 20 (12 generated)
Description was changed from ========== Sets is_reliable for CLD3 if below a minimum byte threshold of 40 bytes. BUG=706606 ========== to ========== Sets is_reliable for CLD3 if below a minimum byte threshold of 40 bytes. BUG=706606 ==========
riesa@chromium.org changed reviewers: + chaotian@chromium.org
riesa@chromium.org changed reviewers: + abakalov@chromium.org
Description was changed from ========== Sets is_reliable for CLD3 if below a minimum byte threshold of 40 bytes. BUG=706606 ========== to ========== Sets is_reliable for CLD3 if below a minimum byte threshold of 50 bytes. BUG=706606 ==========
Looks good to me, thanks Jason!
The CQ bit was checked by riesa@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
riesa@chromium.org changed reviewers: + rdevlin.cronin@chromium.org - chaotian@chromium.org
On 2017/04/03 20:31:00, riesa wrote: > mailto:riesa@chromium.org changed reviewers: > + mailto:rdevlin.cronin@chromium.org > - mailto:chaotian@chromium.org +rdevlin.cronin@ for OWNERS approval
This mostly seems fine. But, since this will affect a public extension API, can we either unrestrict the current bug or file a new public bug (without restricted) info so that other extensions can see the motivation for this change? https://codereview.chromium.org/2780323002/diff/20001/extensions/renderer/i18... File extensions/renderer/i18n_custom_bindings.cc (right): https://codereview.chromium.org/2780323002/diff/20001/extensions/renderer/i18... extensions/renderer/i18n_custom_bindings.cc:323: // Note that when is_reliable is false, the TranslateExtension .js code This is a public API, so we shouldn't include implementation details of a specific extension (even in comments)
On 2017/04/03 20:46:10, Devlin wrote: > This mostly seems fine. But, since this will affect a public extension API, can > we either unrestrict the current bug or file a new public bug (without > restricted) info so that other extensions can see the motivation for this > change? Done. > > https://codereview.chromium.org/2780323002/diff/20001/extensions/renderer/i18... > File extensions/renderer/i18n_custom_bindings.cc (right): > > https://codereview.chromium.org/2780323002/diff/20001/extensions/renderer/i18... > extensions/renderer/i18n_custom_bindings.cc:323: // Note that when is_reliable > is false, the TranslateExtension .js code > This is a public API, so we shouldn't include implementation details of a > specific extension (even in comments) Done.
Thanks! LGTM
The CQ bit was checked by riesa@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491254661170390,
"parent_rev": "c5bd9a545c026646b4f9bc35aba650ff01c87edd", "commit_rev":
"88953d9c7663f797a6c92b8b764812d0e84ef8d9"}
Message was sent while issue was closed.
Description was changed from ========== Sets is_reliable for CLD3 if below a minimum byte threshold of 50 bytes. BUG=706606 ========== to ========== Sets is_reliable for CLD3 if below a minimum byte threshold of 50 bytes. BUG=706606 Review-Url: https://codereview.chromium.org/2780323002 Cr-Commit-Position: refs/heads/master@{#461560} Committed: https://chromium.googlesource.com/chromium/src/+/88953d9c7663f797a6c92b8b7648... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/88953d9c7663f797a6c92b8b7648... |
