Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h

Issue 2780313002: [WIP] Refactor DocumentMarker (Closed)
Patch Set: Move accessor methods into derived classes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h
diff --git a/third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h b/third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h
index 6165d8dfb4f7402b6b868ef3ae02b9bc7d6e76ed..2f22cc5b552d2e8e16532bc676591d508248f167 100644
--- a/third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h
+++ b/third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h
@@ -5,6 +5,7 @@
#ifndef CompositionMarkerList_h
#define CompositionMarkerList_h
+#include "core/editing/markers/CompositionMarker.h"
#include "core/editing/markers/EditingMarkerList.h"
namespace blink {
@@ -15,6 +16,8 @@ class CORE_EXPORT CompositionMarkerList final : public EditingMarkerList {
DocumentMarker::MarkerType allowedMarkerType() const final;
+ CompositionMarker* at(size_t index) final;
Xiaocheng 2017/03/31 02:01:01 virtual |at()| should be in some previous patch.
rlanday 2017/03/31 17:40:41 I don't think this makes sense, there is no Compos
Xiaocheng 2017/03/31 19:59:18 Yeah, you're right!
+
DISALLOW_COPY_AND_ASSIGN(CompositionMarkerList);
};

Powered by Google App Engine
This is Rietveld 408576698