third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h - Issue 2780313002: [WIP] Refactor DocumentMarker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h

Issue 2780313002: [WIP] Refactor DocumentMarker (Closed)

Patch Set: Move accessor methods into derived classes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.cpp » ('j') | third_party/WebKit/Source/core/editing/markers/DocumentMarker.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CompositionMarkerList_h	5 #ifndef CompositionMarkerList_h

6 #define CompositionMarkerList_h	6 #define CompositionMarkerList_h

7	7

	8 #include "core/editing/markers/CompositionMarker.h"

8 #include "core/editing/markers/EditingMarkerList.h"	9 #include "core/editing/markers/EditingMarkerList.h"

9	10

10 namespace blink {	11 namespace blink {

11	12

12 class CORE_EXPORT CompositionMarkerList final : public EditingMarkerList {	13 class CORE_EXPORT CompositionMarkerList final : public EditingMarkerList {

13 public:	14 public:

14 explicit CompositionMarkerList();	15 explicit CompositionMarkerList();

15	16

16 DocumentMarker::MarkerType allowedMarkerType() const final;	17 DocumentMarker::MarkerType allowedMarkerType() const final;

17	18

	19 CompositionMarker* at(size_t index) final;
	Xiaocheng 2017/03/31 02:01:01 virtual \|at()\| should be in some previous patch. virtual \|at()\| should be in some previous patch. rlanday 2017/03/31 17:40:41 I don't think this makes sense, there is no Compos Show quoted text On 2017/03/31 at 02:01:01, Xiaocheng wrote: > virtual \|at()\| should be in some previous patch. I don't think this makes sense, there is no CompositionMarker class until this patch, so this method would be exactly the same as its parent... Xiaocheng 2017/03/31 19:59:18 Yeah, you're right! Show quoted text On 2017/03/31 at 17:40:41, rlanday wrote: > On 2017/03/31 at 02:01:01, Xiaocheng wrote: > > virtual \|at()\| should be in some previous patch. > > I don't think this makes sense, there is no CompositionMarker class until this patch, so this method would be exactly the same as its parent... Yeah, you're right!
	20

18 DISALLOW_COPY_AND_ASSIGN(CompositionMarkerList);	21 DISALLOW_COPY_AND_ASSIGN(CompositionMarkerList);

19 };	22 };

20	23

21 } // namespace blink	24 } // namespace blink

22	25

23 #endif // CompositionMarkerList_h	26 #endif // CompositionMarkerList_h

OLD	NEW