Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2780293002: [Tracing] Remove unused variable kRuntimeCallStatsTracingEnabled. (Closed)

Created:
3 years, 8 months ago by lpy
Modified:
3 years, 8 months ago
Reviewers:
fmeawad
CC:
v8-reviews_googlegroups.com, mattloring
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[Tracing] Remove unused variable kRuntimeCallStatsTracingEnabled. kRuntimeCallStatsTracingEnabled was used as a global flag for runtime stats in tracing, now it is no longer used. TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2780293002 Cr-Commit-Position: refs/heads/master@{#44249} Committed: https://chromium.googlesource.com/v8/v8/+/5d990dbfb7c345121bb84863a4c7d790e502023d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/tracing/trace-event.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
lpy
ptal
3 years, 8 months ago (2017-03-29 20:42:30 UTC) #4
fmeawad
On 2017/03/29 20:42:30, lpy wrote: > ptal Can you put the put the variable name ...
3 years, 8 months ago (2017-03-29 20:44:38 UTC) #7
fmeawad
lgtm
3 years, 8 months ago (2017-03-29 20:45:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780293002/1
3 years, 8 months ago (2017-03-29 21:15:34 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 21:16:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5d990dbfb7c345121bb84863a4c7d790e50...

Powered by Google App Engine
This is Rietveld 408576698