Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2780283002: PPC/s390: [async-iteration] implement AsyncGenerator (Closed)

Created:
3 years, 8 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [async-iteration] implement AsyncGenerator Port bf463c4dc080abb1ae39c6f0a93e6a95867b0ca3 Original Commit Message: - Introduce new struct AsyncGeneratorRequest, which holds information pertinent to resuming execution of an AsyncGenerator, such as the Promise associated with the async generator request. It is intended to be used as a singly linked list, and holds a pointer to the next item in te queue. - Introduce JSAsyncGeneratorObject (subclass of JSGeneratorObject), which includes several new internal fields (`queue` which contains a singly linked list of AsyncGeneratorRequest objects, and `await_input` which contains the sent value from an Await expression (This is necessary to prevent function.sent (used by yield*) from having the sent value observably overwritten during execution). - Modify SuspendGenerator to accept a set of Flags, which indicate whether the suspend is for a Yield or Await, and whether it takes place on an async generator or ES6 generator. - Introduce interpreter intrinsics and TF intrinsic lowering for accessing the await input of an async generator - Modify the JSGeneratorStore operator to understand whether or not it's suspending for a normal yield, or an AsyncGenerator Await. This ensures appropriate registers are stored. - Add versions of ResumeGeneratorTrampoline which store the input value in a different field depending on wether it's an AsyncGenerator Await resume, or an ordinary resume. Also modifies whether debug code will assert that the generator object is a JSGeneratorObject or a JSAsyncGeneratorObject depending on the resume type. R=caitp@igalia.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5855 LOG=N Review-Url: https://codereview.chromium.org/2780283002 Cr-Commit-Position: refs/heads/master@{#44247} Committed: https://chromium.googlesource.com/v8/v8/+/a857e3d0f37ae39a170e95138f9f16f90f1947e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -10 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +26 lines, -5 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +26 lines, -5 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 8 months ago (2017-03-29 19:54:49 UTC) #1
john.yan
lgtm
3 years, 8 months ago (2017-03-29 19:59:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780283002/1
3 years, 8 months ago (2017-03-29 20:00:15 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:31:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a857e3d0f37ae39a170e95138f9f16f90f1...

Powered by Google App Engine
This is Rietveld 408576698