Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 2780233002: Revert of [scheduler] Split suspendable tq from unthrottled tq. (Closed)

Created:
3 years, 8 months ago by rnephew (Reviews Here)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org, rwlbuis, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [scheduler] Split suspendable tq from unthrottled tq. (patchset #4 id:60001 of https://codereview.chromium.org/2754673002/ ) Reason for revert: Causing failures in perf tests. Reverting to confirm it is the culprit. crbug.com/706108 crbug.com/706104 Original issue's description: > [scheduler] Add suspendable task queue. > > Add suspendable task queue to avoid running (and cancelling) callbacks > when execution context is suspended. > > R=skyostil@chromium.org,alexclarke@chromium.org,haraken@chromium.org > CC=nhiroki@chromium.org,tzik@chromium.org > BUG=700792 > > Review-Url: https://codereview.chromium.org/2754673002 > Cr-Commit-Position: refs/heads/master@{#459787} > Committed: https://chromium.googlesource.com/chromium/src/+/12e16766adec5bb1e5cdd73d3cd8f5016b59ce18 TBR=alexclarke@chromium.org,haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=700792 Review-Url: https://codereview.chromium.org/2780233002 Cr-Commit-Position: refs/heads/master@{#460519} Committed: https://chromium.googlesource.com/chromium/src/+/78c7038fe6f981a9045d7d32d9f531ebb098fd80

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
rnephew (Reviews Here)
Created Revert of [scheduler] Split suspendable tq from unthrottled tq.
3 years, 8 months ago (2017-03-29 18:10:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780233002/1
3 years, 8 months ago (2017-03-29 18:10:46 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:26:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78c7038fe6f981a9045d7d32d9f5...

Powered by Google App Engine
This is Rietveld 408576698