[regexp] Add support for dotAll flag

[regexp] Add support for dotAll flag

The dotAll flag changes behavior of the dot '.' character to match every
possible single character instead of excluding certain line terminators.

The implementation is staged behind --harmony-regexp-dotall.

Spec proposal: https://github.com/mathiasbynens/es-regexp-dotall-flag

BUG=v8:6172
Review-Url: https://codereview.chromium.org/2780173002
Cr-Commit-Position: refs/heads/master@{#44295}
Committed: https://chromium.googlesource.com/v8/v8/+/cec39ad1ade5b38a7b203e9cc64cca867196f33a

[jgruber, 2017-03-29 14:37:07]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 14:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 14:38:26]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23529)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/20022)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37985)

[jgruber, 2017-03-29 14:44:16]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 14:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 15:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:16:29]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-03-29 15:21:54]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:21:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-29 15:26:26]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2017-03-29 15:34:44]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:34:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mathias, 2017-03-29 16:10:41]

mathias@qiwi.be changed reviewers:
+ mathias@qiwi.be

[mathias, 2017-03-29 16:10:42]

https://codereview.chromium.org/2780173002/diff/60001/test/mjsunit/harmony/re...
File test/mjsunit/harmony/regexp-dotall.js (right):

https://codereview.chromium.org/2780173002/diff/60001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-dotall.js:73: assertFalse(re.test("\u2029"));
Let’s test U+180E as well, since it used to be a whitespace character but isn’t
anymore.
(https://github.com/mathiasbynens/regexpu-core/commit/9b10d2a597d4e56b236cae0f...)

[commit-bot: I haz the power, 2017-03-29 16:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:18:34]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-03-30 07:32:26]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 07:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-30 07:32:39]

https://codereview.chromium.org/2780173002/diff/60001/test/mjsunit/harmony/re...
File test/mjsunit/harmony/regexp-dotall.js (right):

https://codereview.chromium.org/2780173002/diff/60001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-dotall.js:73: assertFalse(re.test("\u2029"));
On 2017/03/29 16:10:42, mathias wrote:
> Let’s test U+180E as well, since it used to be a whitespace character but
isn’t
> anymore.
>
(https://github.com/mathiasbynens/regexpu-core/commit/9b10d2a597d4e56b236cae0f...)

Done. The expectation for U+180E is to match '.' in all cases.

[mathias, 2017-03-30 07:34:59]

lgtm

[commit-bot: I haz the power, 2017-03-30 07:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 07:59:09]

Dry run: This issue passed the CQ dry run.

[erikcorry, 2017-03-30 13:02:18]

erikcorry@google.com changed reviewers:
+ erikcorry@google.com

[erikcorry, 2017-03-30 13:02:19]

I think there should be a second test without the --harmony.... flag that tests
that the various dotall features are not activated and throw the necessary
syntax errors etc.

[jgruber, 2017-03-30 13:21:16]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 13:21:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-30 13:22:53]

On 2017/03/30 13:02:19, erikcorry wrote:
> I think there should be a second test without the --harmony.... flag that
tests
> that the various dotall features are not activated and throw the necessary
> syntax errors etc.

Added regexp-dotall-disabled.js.

[jgruber, 2017-03-30 13:23:15]

jgruber@chromium.org changed reviewers:
+ marja@chromium.org

[jgruber, 2017-03-30 13:23:16]

+marja@ for parsing/, PTAL

[erikcorry, 2017-03-30 13:28:30]

https://codereview.chromium.org/2780173002/diff/100001/test/mjsunit/harmony/r...
File test/mjsunit/harmony/regexp-dotall-disabled.js (right):

https://codereview.chromium.org/2780173002/diff/100001/test/mjsunit/harmony/r...
test/mjsunit/harmony/regexp-dotall-disabled.js:18: let re = /./gimyu;
You could also check

("dotAll" in re)

to see if the property is there with value "undefined", or it is really not
there.

[erikcorry, 2017-03-30 13:28:32]

lgtm

[commit-bot: I haz the power, 2017-03-30 13:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 13:53:55]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-03-30 14:04:26]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 14:04:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 14:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 14:32:43]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-31 05:55:04]

On 2017/03/30 13:28:32, erikcorry wrote:
> lgtm

LGTM!

[marja, 2017-03-31 09:16:04]

parsing lgtm

[jgruber, 2017-03-31 09:17:00]

Thanks all, landing.

https://codereview.chromium.org/2780173002/diff/100001/test/mjsunit/harmony/r...
File test/mjsunit/harmony/regexp-dotall-disabled.js (right):

https://codereview.chromium.org/2780173002/diff/100001/test/mjsunit/harmony/r...
test/mjsunit/harmony/regexp-dotall-disabled.js:18: let re = /./gimyu;
On 2017/03/30 13:28:30, erikcorry wrote:
> You could also check
> 
> ("dotAll" in re)
> 
> to see if the property is there with value "undefined", or it is really not
> there.

Done.

[jgruber, 2017-03-31 09:17:13]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-31 09:17:13]

The patchset sent to the CQ was uploaded after l-g-t-m from mathias@qiwi.be,
erikcorry@google.com
Link to the patchset: https://codereview.chromium.org/2780173002/#ps120001
(title: "Address comments")

[commit-bot: I haz the power, 2017-03-31 09:17:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 09:20:14]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490951833217290,
"parent_rev": "85ff725cf4d48361f8c12495f23f68dd48dd2e29", "commit_rev":
"cec39ad1ade5b38a7b203e9cc64cca867196f33a"}

[commit-bot: I haz the power, 2017-03-31 09:20:21]

Description was changed from

==========
[regexp] Add support for dotAll flag

The dotAll flag changes behavior of the dot '.' character to match every
possible single character instead of excluding certain line terminators.

The implementation is staged behind --harmony-regexp-dotall.

Spec proposal: https://github.com/mathiasbynens/es-regexp-dotall-flag

BUG=v8:6172
==========

to

==========
[regexp] Add support for dotAll flag

The dotAll flag changes behavior of the dot '.' character to match every
possible single character instead of excluding certain line terminators.

The implementation is staged behind --harmony-regexp-dotall.

Spec proposal: https://github.com/mathiasbynens/es-regexp-dotall-flag

BUG=v8:6172

Review-Url: https://codereview.chromium.org/2780173002
Cr-Commit-Position: refs/heads/master@{#44295}
Committed:
https://chromium.googlesource.com/v8/v8/+/cec39ad1ade5b38a7b203e9cc64cca86719...
==========

[commit-bot: I haz the power, 2017-03-31 09:20:22]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/cec39ad1ade5b38a7b203e9cc64cca86719...