Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2780073002: Disable DirectComposition underlays and complex transforms by default. (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable DirectComposition underlays and complex transforms by default. Having these enabled can use excessive power sometimes (depending on the layout of content above and the damage rect), so disable them for now. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2780073002 Cr-Commit-Position: refs/heads/master@{#460538} Committed: https://chromium.googlesource.com/chromium/src/+/a86969ccaa323041accc500dad6b73bfe1242da4

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M cc/output/dc_layer_overlay.cc View 1 2 4 chunks +13 lines, -2 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 4 chunks +7 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
jbauman
3 years, 8 months ago (2017-03-28 23:25:38 UTC) #6
ccameron
lgtm
3 years, 8 months ago (2017-03-29 20:55:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780073002/40001
3 years, 8 months ago (2017-03-29 21:05:18 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 21:12:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a86969ccaa323041accc500dad6b...

Powered by Google App Engine
This is Rietveld 408576698