Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2780063003: [M58 Branch (merge)] Fix the test build. (Closed)

Created:
3 years, 8 months ago by Ilya Sherman
Modified:
3 years, 8 months ago
Reviewers:
Maria
CC:
chromium-reviews, kalyank, sadrul, aluo
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[M58 Branch (merge)] Fix the test build. BUG=694884 TEST=build, run tests TBR=mariakhomenko@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2780063003 Cr-Commit-Position: refs/branch-heads/3029@{#468} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8554506cd7328aa0c43e193d6e45920c051ee310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ilya Sherman
3 years, 8 months ago (2017-03-29 04:53:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780063003/1
3 years, 8 months ago (2017-03-29 04:54:53 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-03-29 04:54:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780063003/1
3 years, 8 months ago (2017-03-29 04:56:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8554506cd7328aa0c43e193d6e45920c051ee310
3 years, 8 months ago (2017-03-29 05:00:00 UTC) #11
Maria
3 years, 8 months ago (2017-03-30 05:47:39 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698