Aura-Mus: Allocate a LocalSurfaceId on size change

Aura-Mus: Allocate a LocalSurfaceId on size change

If the window type is EMBED_IN_OWNER, or TOP_LEVEL_IN_WM, then allocate
a cc::LocalSurfaceId on size change and propagate that new LocalSurfaceId
down to the WindowTreeHost of the embedded client. The embedded client
will use that LocalSurfaceId to submit CompositorFrames.

If surface synchronization is enabled (subsequent patch), then the embedder
can immediately embed the surface ID (if the FrameSinkId is available), and
submit its own CompositorFrame with that embedding. The parent's CompositorFrame
will block until the embedded client submits a CompositorFrame or a deadline is
hit.

BUG=672962
Review-Url: https://codereview.chromium.org/2780043002
Cr-Commit-Position: refs/heads/master@{#460597}
Committed: https://chromium.googlesource.com/chromium/src/+/df6186f7c0a8611fdd4425338cc6a1dceeaa2e7e

[Fady Samuel, 2017-03-28 22:31:20]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-03-28 23:35:34]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2017-03-28 23:35:34]

PTAL Scott! I have GetOrAllocateSurfaceId so that I can use the before resize
LocalSurfaceId in InFlightBoundsChange.

[sky, 2017-03-29 00:07:35]

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_mus.h
File ui/aura/mus/window_mus.h (right):

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_mus.h#ne...
ui/aura/mus/window_mus.h:87: virtual const cc::LocalSurfaceId&
GetLocalSurfaceId() = 0;
Move this beneath all the other SetFooFromServer functions.

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_tree_cli...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_tree_cli...
ui/aura/mus/window_tree_client.cc:626: local_surface_id);
Please add test coverage that the id sent to the server changes when the bounds
change. It would also be good to verify the revert logic works correctly for
local_surface_ids.

[commit-bot: I haz the power, 2017-03-29 00:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 00:35:16]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Fady Samuel, 2017-03-29 22:10:14]

PTAL Scott! Thanks! :-)

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_mus.h
File ui/aura/mus/window_mus.h (right):

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_mus.h#ne...
ui/aura/mus/window_mus.h:87: virtual const cc::LocalSurfaceId&
GetLocalSurfaceId() = 0;
On 2017/03/29 00:07:35, sky wrote:
> Move this beneath all the other SetFooFromServer functions.

Done.

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_tree_cli...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2780043002/diff/1/ui/aura/mus/window_tree_cli...
ui/aura/mus/window_tree_client.cc:626: local_surface_id);
On 2017/03/29 00:07:35, sky wrote:
> Please add test coverage that the id sent to the server changes when the
bounds
> change. It would also be good to verify the revert logic works correctly for
> local_surface_ids.

Done! Found a bug a fixed it. I've added two tests and modified an existing test
to verify changes to LocalSurfaceId.

This could stand to use more test coverage. I will add more in my subsequent CL.

[Fady Samuel, 2017-03-29 22:12:33]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-29 23:26:35]

LGTM

[commit-bot: I haz the power, 2017-03-30 00:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 00:13:05]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-03-30 00:23:24]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-03-30 00:24:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 00:31:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490833404693430,
"parent_rev": "314a2aec9a9f1b4de5be0a4c215a4f7c73da1d87", "commit_rev":
"df6186f7c0a8611fdd4425338cc6a1dceeaa2e7e"}

[commit-bot: I haz the power, 2017-03-30 00:53:54]

Description was changed from

==========
Aura-Mus: Allocate a LocalSurfaceId on size change

If the window type is EMBED_IN_OWNER, or TOP_LEVEL_IN_WM, then allocate
a cc::LocalSurfaceId on size change and propagate that new LocalSurfaceId
down to the WindowTreeHost of the embedded client. The embedded client
will use that LocalSurfaceId to submit CompositorFrames.

If surface synchronization is enabled (subsequent patch), then the embedder
can immediately embed the surface ID (if the FrameSinkId is available), and
submit its own CompositorFrame with that embedding. The parent's CompositorFrame
will block until the embedded client submits a CompositorFrame or a deadline is
hit.

BUG=672962
==========

to

==========
Aura-Mus: Allocate a LocalSurfaceId on size change

If the window type is EMBED_IN_OWNER, or TOP_LEVEL_IN_WM, then allocate
a cc::LocalSurfaceId on size change and propagate that new LocalSurfaceId
down to the WindowTreeHost of the embedded client. The embedded client
will use that LocalSurfaceId to submit CompositorFrames.

If surface synchronization is enabled (subsequent patch), then the embedder
can immediately embed the surface ID (if the FrameSinkId is available), and
submit its own CompositorFrame with that embedding. The parent's CompositorFrame
will block until the embedded client submits a CompositorFrame or a deadline is
hit.

BUG=672962

Review-Url: https://codereview.chromium.org/2780043002
Cr-Commit-Position: refs/heads/master@{#460597}
Committed:
https://chromium.googlesource.com/chromium/src/+/df6186f7c0a8611fdd4425338cc6...
==========

[commit-bot: I haz the power, 2017-03-30 00:53:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/df6186f7c0a8611fdd4425338cc6...