Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2780033003: Fix refactoring regression in ChromeViewsDelegateLinux (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix refactoring regression in ChromeViewsDelegateLinux You can see what the old code was like here, specifically lines 393 and 395 https://chromium.googlesource.com/chromium/src/+/2c407ccc88aae08641fcb667277df2b08a2f251a/chrome/browser/ui/views/chrome_views_delegate.cc BUG=none TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2780033003 Cr-Commit-Position: refs/heads/master@{#460442} Committed: https://chromium.googlesource.com/chromium/src/+/158d97ab48e2c8343051e439db4f470151039ee5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/chrome_views_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 8 months ago (2017-03-29 15:13:38 UTC) #1
Elliot Glaysher
lgtm
3 years, 8 months ago (2017-03-29 17:15:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780033003/1
3 years, 8 months ago (2017-03-29 17:28:49 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:38:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/158d97ab48e2c8343051e439db4f...

Powered by Google App Engine
This is Rietveld 408576698