chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc - Issue 2780003003: Send an event to the page load metrics to track resource starting.

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)

Patch Set: FREEZE.unindexed - took merge and fixed it up Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

index 3d222d7722c7e970d729478e0e3e617bc27e836b..f1d2e06040666f605629e84e607bf5dee0ccd1f4 100644

--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

@@ -156,7 +156,8 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {

SimulateLoadedResource({false /* was_cached */,

1024 * 40 /* raw_body_bytes */,

0 /* original_network_content_length */,

- nullptr /* data_reduction_proxy_data */});

+ nullptr /* data_reduction_proxy_data */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

@@ -168,11 +169,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {

SimulateLoadedResource({false /* was_cached */,

1024 * 20 /* raw_body_bytes */,

0 /* original_network_content_length */,

- nullptr /* data_reduction_proxy_data */});

+ nullptr /* data_reduction_proxy_data */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,

0 /* original_network_content_length */,

- nullptr /* data_reduction_proxy_data */});

+ nullptr /* data_reduction_proxy_data */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

histogram_tester().ExpectTotalCount(

internal::kHistogramSubresourceFilterCount, 1);

@@ -251,7 +254,8 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {

SimulateLoadedResource({false /* was_cached */,

1024 * 40 /* raw_body_bytes */,

0 /* original_network_content_length */,

- nullptr /* data_reduction_proxy_data */});

+ nullptr /* data_reduction_proxy_data */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

@@ -263,11 +267,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {

SimulateLoadedResource({false /* was_cached */,

1024 * 20 /* raw_body_bytes */,

0 /* original_network_content_length */,

- nullptr /* data_reduction_proxy_data */});

+ nullptr /* data_reduction_proxy_data */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,

0 /* original_network_content_length */,

- nullptr /* data_reduction_proxy_data */});

+ nullptr /* data_reduction_proxy_data */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

histogram_tester().ExpectTotalCount(

internal::kHistogramSubresourceFilterCount, 1);