Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)
Patch Set: FREEZE.unindexed - took merge and fixed it up Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h" 5 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h" 8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h"
9 9
10 namespace { 10 namespace {
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 histogram_tester().ExpectTotalCount( 149 histogram_tester().ExpectTotalCount(
150 internal::kHistogramSubresourceFilterForegroundDuration, 1); 150 internal::kHistogramSubresourceFilterForegroundDuration, 1);
151 } 151 }
152 152
153 TEST_F(SubresourceFilterMetricsObserverTest, Subresources) { 153 TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
154 NavigateAndCommit(GURL(kDefaultTestUrl)); 154 NavigateAndCommit(GURL(kDefaultTestUrl));
155 155
156 SimulateLoadedResource({false /* was_cached */, 156 SimulateLoadedResource({false /* was_cached */,
157 1024 * 40 /* raw_body_bytes */, 157 1024 * 40 /* raw_body_bytes */,
158 0 /* original_network_content_length */, 158 0 /* original_network_content_length */,
159 nullptr /* data_reduction_proxy_data */}); 159 nullptr /* data_reduction_proxy_data */,
160 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
160 161
161 page_load_metrics::PageLoadTiming timing; 162 page_load_metrics::PageLoadTiming timing;
162 timing.navigation_start = base::Time::FromDoubleT(1); 163 timing.navigation_start = base::Time::FromDoubleT(1);
163 page_load_metrics::PageLoadMetadata metadata; 164 page_load_metrics::PageLoadMetadata metadata;
164 metadata.behavior_flags |= 165 metadata.behavior_flags |=
165 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch; 166 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
166 SimulateTimingAndMetadataUpdate(timing, metadata); 167 SimulateTimingAndMetadataUpdate(timing, metadata);
167 168
168 SimulateLoadedResource({false /* was_cached */, 169 SimulateLoadedResource({false /* was_cached */,
169 1024 * 20 /* raw_body_bytes */, 170 1024 * 20 /* raw_body_bytes */,
170 0 /* original_network_content_length */, 171 0 /* original_network_content_length */,
171 nullptr /* data_reduction_proxy_data */}); 172 nullptr /* data_reduction_proxy_data */,
173 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
172 174
173 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */, 175 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
174 0 /* original_network_content_length */, 176 0 /* original_network_content_length */,
175 nullptr /* data_reduction_proxy_data */}); 177 nullptr /* data_reduction_proxy_data */,
178 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
176 179
177 histogram_tester().ExpectTotalCount( 180 histogram_tester().ExpectTotalCount(
178 internal::kHistogramSubresourceFilterCount, 1); 181 internal::kHistogramSubresourceFilterCount, 1);
179 182
180 // Navigate away from the current page to force logging of request and byte 183 // Navigate away from the current page to force logging of request and byte
181 // metrics. 184 // metrics.
182 NavigateToUntrackedUrl(); 185 NavigateToUntrackedUrl();
183 186
184 histogram_tester().ExpectTotalCount( 187 histogram_tester().ExpectTotalCount(
185 internal::kHistogramSubresourceFilterTotalResources, 1); 188 internal::kHistogramSubresourceFilterTotalResources, 1);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 } 247 }
245 248
246 TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) { 249 TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
247 NavigateAndCommit(GURL(kDefaultTestUrl)); 250 NavigateAndCommit(GURL(kDefaultTestUrl));
248 251
249 SimulateMediaPlayed(); 252 SimulateMediaPlayed();
250 253
251 SimulateLoadedResource({false /* was_cached */, 254 SimulateLoadedResource({false /* was_cached */,
252 1024 * 40 /* raw_body_bytes */, 255 1024 * 40 /* raw_body_bytes */,
253 0 /* original_network_content_length */, 256 0 /* original_network_content_length */,
254 nullptr /* data_reduction_proxy_data */}); 257 nullptr /* data_reduction_proxy_data */,
258 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
255 259
256 page_load_metrics::PageLoadTiming timing; 260 page_load_metrics::PageLoadTiming timing;
257 timing.navigation_start = base::Time::FromDoubleT(1); 261 timing.navigation_start = base::Time::FromDoubleT(1);
258 page_load_metrics::PageLoadMetadata metadata; 262 page_load_metrics::PageLoadMetadata metadata;
259 metadata.behavior_flags |= 263 metadata.behavior_flags |=
260 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch; 264 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
261 SimulateTimingAndMetadataUpdate(timing, metadata); 265 SimulateTimingAndMetadataUpdate(timing, metadata);
262 266
263 SimulateLoadedResource({false /* was_cached */, 267 SimulateLoadedResource({false /* was_cached */,
264 1024 * 20 /* raw_body_bytes */, 268 1024 * 20 /* raw_body_bytes */,
265 0 /* original_network_content_length */, 269 0 /* original_network_content_length */,
266 nullptr /* data_reduction_proxy_data */}); 270 nullptr /* data_reduction_proxy_data */,
271 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
267 272
268 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */, 273 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
269 0 /* original_network_content_length */, 274 0 /* original_network_content_length */,
270 nullptr /* data_reduction_proxy_data */}); 275 nullptr /* data_reduction_proxy_data */,
276 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
271 277
272 histogram_tester().ExpectTotalCount( 278 histogram_tester().ExpectTotalCount(
273 internal::kHistogramSubresourceFilterCount, 1); 279 internal::kHistogramSubresourceFilterCount, 1);
274 280
275 // Navigate away from the current page to force logging of request and byte 281 // Navigate away from the current page to force logging of request and byte
276 // metrics. 282 // metrics.
277 NavigateToUntrackedUrl(); 283 NavigateToUntrackedUrl();
278 284
279 histogram_tester().ExpectTotalCount( 285 histogram_tester().ExpectTotalCount(
280 internal::kHistogramSubresourceFilterTotalResources, 1); 286 internal::kHistogramSubresourceFilterTotalResources, 1);
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 histogram_tester().ExpectTotalCount( 336 histogram_tester().ExpectTotalCount(
331 internal::kHistogramSubresourceFilterMediaNetworkBytes, 1); 337 internal::kHistogramSubresourceFilterMediaNetworkBytes, 1);
332 histogram_tester().ExpectBucketCount( 338 histogram_tester().ExpectBucketCount(
333 internal::kHistogramSubresourceFilterMediaNetworkBytes, 60, 1); 339 internal::kHistogramSubresourceFilterMediaNetworkBytes, 60, 1);
334 340
335 histogram_tester().ExpectTotalCount( 341 histogram_tester().ExpectTotalCount(
336 internal::kHistogramSubresourceFilterMediaCacheBytes, 1); 342 internal::kHistogramSubresourceFilterMediaCacheBytes, 1);
337 histogram_tester().ExpectBucketCount( 343 histogram_tester().ExpectBucketCount(
338 internal::kHistogramSubresourceFilterMediaCacheBytes, 10, 1); 344 internal::kHistogramSubresourceFilterMediaCacheBytes, 10, 1);
339 } 345 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698