Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)
Patch Set: Second round of RyanSturm feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4e1fc4fc968a23638baf61829f845ac7baa10efd
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc
@@ -0,0 +1,73 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h"
+
+#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
+
+namespace {
+const char kFakeUrl[] = "http://www.google.com/nothingotseehere.html";
+} // namespace
+
+namespace page_load_metrics {
+
+class ResourceTrackingPageLoadMetricsObserverTest
+ : public page_load_metrics::PageLoadMetricsObserverTestHarness {
+ public:
+ ResourceTrackingPageLoadMetricsObserverTest() : observer_(nullptr) {}
+
+ protected:
+ void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
+ std::unique_ptr<page_load_metrics::ResourceTrackingPageLoadMetricsObserver>
+ observer(
+ new page_load_metrics::ResourceTrackingPageLoadMetricsObserver());
+ // Keep track of the observer pointer so we can check it in the unit test.
+ observer_ = observer.get();
+ tracker->AddObserver(std::move(observer));
+ }
+
+ void SetUp() override {
+ page_load_metrics::PageLoadMetricsObserverTestHarness::SetUp();
Bryan McQuade 2017/04/17 23:32:14 we can omit the override here since we're just inv
Pete Williamson 2017/04/18 18:17:27 Removed.
+ }
+
+ page_load_metrics::ResourceTrackingPageLoadMetricsObserver* observer() {
+ return observer_;
+ }
+
+ private:
+ page_load_metrics::ResourceTrackingPageLoadMetricsObserver* observer_;
+};
+
+TEST_F(ResourceTrackingPageLoadMetricsObserverTest, StartAndFinish) {
+ page_load_metrics::ExtraRequestStartInfo start_info_1{
+ content::ResourceType::RESOURCE_TYPE_IMAGE};
+
+ page_load_metrics::ExtraRequestStartInfo start_info_2{
+ content::ResourceType::RESOURCE_TYPE_IMAGE};
+
+ page_load_metrics::ExtraRequestCompleteInfo done_info = {
+ false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ false /* data_reduction_proxy_used*/,
+ 1024 * 40 /* original_network_content_length */,
+ content::ResourceType::RESOURCE_TYPE_IMAGE};
+
+ // Start the navigation. This will create the page load tracker and register
+ // the observers.
+ NavigateAndCommit(GURL(kFakeUrl));
+
+ // Simulate starting two images, and completing one.
+ SimulateStartedResource(start_info_1);
+ SimulateStartedResource(start_info_2);
+ SimulateLoadedResource(done_info);
+
+ int64_t started = -1;
+ int64_t completed = -1;
+ EXPECT_NE(nullptr, observer());
+ observer()->GetCountsForType(content::ResourceType::RESOURCE_TYPE_IMAGE,
+ &started, &completed);
+ EXPECT_EQ(2, started);
+ EXPECT_EQ(1, completed);
+}
+
+} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698