chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h - Issue 2780003003: Send an event to the page load metrics to track resource starting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)

Patch Set: Second round of RyanSturm feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc ('K') | « chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h

index f512bedee4995be5aa25d6654e254c8951a037b3..f6301abbceefefd89a85c54672f571d4c6170f59 100644

--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h

@@ -70,8 +70,8 @@ class SubresourceFilterMetricsObserver

const page_load_metrics::PageLoadExtraInfo& info) override;

void OnComplete(const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) override;

- void OnLoadedResource(

- const page_load_metrics::ExtraRequestInfo& extra_request_info) override;

+ void OnLoadedResource(const page_load_metrics::ExtraRequestCompleteInfo&

+ extra_request_complete_info) override;

void OnParseStop(const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) override;

void OnFirstContentfulPaint(