Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2779983004: Disable a few failing tests. (Closed)

Created:
3 years, 8 months ago by Finnur
Modified:
3 years, 8 months ago
Reviewers:
chrishtr, hugoh_UTC2
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable a few failing tests. BUG=706371, 706375, 706119 NOTRY=true TBR=chrishtr Review-Url: https://codereview.chromium.org/2779983004 Cr-Commit-Position: refs/heads/master@{#460370} Committed: https://chromium.googlesource.com/chromium/src/+/e4cb1157a0036e40bf59382eeead754bc8b40bdd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 3 chunks +17 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (6 generated)
Finnur
3 years, 8 months ago (2017-03-29 13:27:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779983004/1
3 years, 8 months ago (2017-03-29 13:28:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e4cb1157a0036e40bf59382eeead754bc8b40bdd
3 years, 8 months ago (2017-03-29 13:33:58 UTC) #8
hugoh_UTC2
https://codereview.chromium.org/2779983004/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2779983004/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode2681 third_party/WebKit/LayoutTests/TestExpectations:2681: crbug.com/706119 fast/forms/focus-selection-textarea.html [ Failure ] It was only the ...
3 years, 8 months ago (2017-03-30 04:22:56 UTC) #10
hugoh_UTC2
3 years, 8 months ago (2017-03-30 10:27:18 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/2779983004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2779983004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:2681: crbug.com/706119
fast/forms/focus-selection-textarea.html [ Failure ]
On 2017/03/30 04:22:56, hugoh_UTC9 wrote:
> It was only the Windows bots that flaked, right? Could we re-enable this test
> for Linux and Mac?
I made attempt to fix the tests on all platforms:
https://codereview.chromium.org/2786953002/ .

Powered by Google App Engine
This is Rietveld 408576698