Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2779973005: Fix errors when running against staging (Closed)

Created:
3 years, 8 months ago by Robert Ogden
Modified:
3 years, 8 months ago
Reviewers:
RyanSturm, dougarnett
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org, bustamante
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix errors when running against staging BUG= Review-Url: https://codereview.chromium.org/2779973005 Cr-Commit-Position: refs/heads/master@{#460578} Committed: https://chromium.googlesource.com/chromium/src/+/78965a2abbe5d4365204bbc46933a523144a1eb7

Patch Set 1 #

Patch Set 2 : Add skip on lite page test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M tools/chrome_proxy/webdriver/bypass.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/chrome_proxy/webdriver/common.py View 2 chunks +10 lines, -6 lines 0 comments Download
M tools/chrome_proxy/webdriver/lite_page.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/chrome_proxy/webdriver/lofi.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Robert Ogden
3 years, 8 months ago (2017-03-28 22:17:26 UTC) #3
dougarnett
lgtm
3 years, 8 months ago (2017-03-28 22:50:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779973005/1
3 years, 8 months ago (2017-03-28 22:53:57 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-28 22:53:59 UTC) #8
Robert Ogden
Ryan, please take a look
3 years, 8 months ago (2017-03-28 22:54:45 UTC) #10
RyanSturm
lgtm
3 years, 8 months ago (2017-03-29 21:47:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779973005/20001
3 years, 8 months ago (2017-03-29 21:49:23 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 23:36:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/78965a2abbe5d4365204bbc46933...

Powered by Google App Engine
This is Rietveld 408576698