Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2779973002: Initialize contained_mixed_form in SecurityStyleExplanations (Closed)

Created:
3 years, 8 months ago by elawrence
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize contained_mixed_form in SecurityStyleExplanations A recent change (crrev.com/2765423002/) introduced a new boolean field which was not correctly initialized to false. This change initializes the field. BUG=706080 Review-Url: https://codereview.chromium.org/2779973002 Cr-Commit-Position: refs/heads/master@{#460249} Committed: https://chromium.googlesource.com/chromium/src/+/56b7a0680cfd690e899e0115a3a986d165c7c6fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/browser/security_style_explanations.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pfeldman
lgtm
3 years, 8 months ago (2017-03-28 18:54:56 UTC) #2
elawrence
PTAL?
3 years, 8 months ago (2017-03-28 18:56:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779973002/1
3 years, 8 months ago (2017-03-28 18:57:46 UTC) #5
elawrence
On 2017/03/28 18:56:28, elawrence wrote: > PTAL? Oops, you already did. thanks!
3 years, 8 months ago (2017-03-28 18:58:00 UTC) #6
commit-bot: I haz the power
CQ has no permission to schedule in bucket master.tryserver.chromium.linux
3 years, 8 months ago (2017-03-28 21:14:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779973002/1
3 years, 8 months ago (2017-03-28 21:43:40 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 00:26:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56b7a0680cfd690e899e0115a3a9...

Powered by Google App Engine
This is Rietveld 408576698