Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2779933002: Add a screen to migrate filesystem encryption from eCryptfs to ext4 crypto. (Closed)

Created:
3 years, 8 months ago by fukino
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, hashimoto+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a screen to migrate filesystem encryption from eCryptfs to ext4 crypto. Background: We are going to change the cryptohome's encryption from eCryptfs to ext4 crypto (Dircrypto). The migration is necessary for users who want to run the latest Android system. What we need to do: When an existing user sign in to the device and the user's cryptohome is encrypted in old format, we should show a UI to ask the user to migrate the encryption. Implementation detail: If we request cryptohome's MountEx with force_dircrypto=true and the existing user's cryptohome is encrypted in old format, Chrome will receive an error CRYPTOHOME_ERROR_MOUNT_OLD_ENCRYPTION. (At this moment, I added a flag in fake_cryptohome_client to return this error.) On receiving this error, ExistingUserController shows the migration UI through WizardController. I'll implement the actual migration process inside the added UI in a separate CL. BUG=706017 TEST=on Linux, run chrome (for ChromeOS) with --test-encryption-migration-ui --login-manager and sign in to an existing user should show a simple UI saying "Encryption Migration UI". CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2779933002 Cr-Commit-Position: refs/heads/master@{#460295} Committed: https://chromium.googlesource.com/chromium/src/+/39ee152a5b5021ca5489011cca1262c283c7d180

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -5 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_screen.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_screen.cc View 1 chunk +5 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/login/screens/encryption_migration_screen.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/encryption_migration_screen.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/encryption_migration_screen_view.h View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/screen_exit_code.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_non_lock_shared.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_screens.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_encryption_migration.html View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_encryption_migration.js View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M chromeos/login/auth/auth_status_consumer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/login/auth/auth_status_consumer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M chromeos/login/auth/login_performer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/login/auth/login_performer.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
fukino
Hi Xiyuan, could you take a look? As the migration is not a part of ...
3 years, 8 months ago (2017-03-28 16:31:20 UTC) #8
xiyuan
lgtm Agree that this does not need to be in oobe since it only affects ...
3 years, 8 months ago (2017-03-28 17:15:05 UTC) #10
fukino
Thank you for the review! I'll go with the current approach, and will move the ...
3 years, 8 months ago (2017-03-29 01:03:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779933002/40001
3 years, 8 months ago (2017-03-29 01:05:32 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/410346) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 8 months ago (2017-03-29 02:56:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779933002/40001
3 years, 8 months ago (2017-03-29 05:49:47 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 05:56:20 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39ee152a5b5021ca5489011cca12...

Powered by Google App Engine
This is Rietveld 408576698