Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2779903005: gpu: Destroy the BindingSet on the thread it's bound on. (Closed)

Created:
3 years, 8 months ago by sadrul
Modified:
3 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, rjkroege
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Destroy the BindingSet on the thread it's bound on. The BindingSet for mojom.GpuService is bound on the IO thread. So make sure it gets destroyed on the IO thread too. BUG=706357 Review-Url: https://codereview.chromium.org/2779903005 Cr-Commit-Position: refs/heads/master@{#460496} Committed: https://chromium.googlesource.com/chromium/src/+/0835f286c5ed94154f48158a26e84b37543f827d

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M services/ui/gpu/gpu_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 4 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
sadrul
3 years, 8 months ago (2017-03-29 18:31:14 UTC) #9
Ken Rockot(use gerrit already)
lgtm
3 years, 8 months ago (2017-03-29 19:10:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779903005/20001
3 years, 8 months ago (2017-03-29 19:34:51 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:42:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0835f286c5ed94154f48158a26e8...

Powered by Google App Engine
This is Rietveld 408576698