[iOS] Add application target as dependency of xctest module target.

[iOS] Add application target as dependency of xctest module target.

Previously, clicking on the "Play" button near a test in the test
navigator doesn't automatically re-build the application target, so that
tests don't test the current state of the code, but the one when it was
last compiled.

This CL fixes the problem by adding corresponding application target as
a dependency of xctest module target.

BUG=705005
Review-Url: https://codereview.chromium.org/2779833002
Cr-Commit-Position: refs/heads/master@{#460805}
Committed: https://chromium.googlesource.com/chromium/src/+/611254763b178dd9a1680e1e107a09aefb1267cb

[liaoyuke, 2017-03-28 04:43:38]

Description was changed from

==========
[iOS] Add application target as dependency of xctest module target.

Previously, clicking on the "Play" button near a test in the test
navigator doesn't automatically re-build the application target, so that
tests don't test the current state of the code, but the one when it was
last compiled.

This CL fixes the problem by adding corresponding application target as
a dependency of xctest module target.

BUG=705005
==========

to

==========
[iOS] Add application target as dependency of xctest module target.

Previously, clicking on the "Play" button near a test in the test
navigator doesn't automatically re-build the application target, so that
tests don't test the current state of the code, but the one when it was
last compiled.

This CL fixes the problem by adding corresponding application target as
a dependency of xctest module target.

BUG=705005
==========

[liaoyuke, 2017-03-28 04:43:38]

liaoyuke@chromium.org changed reviewers:
+ sdefresne@chromium.org

[liaoyuke, 2017-03-28 04:44:18]

Hey Sylvain,

PTAL.

Thank you very much!

[sdefresne, 2017-03-28 14:19:33]

lgtm

https://codereview.chromium.org/2779833002/diff/1/tools/gn/xcode_writer.cc
File tools/gn/xcode_writer.cc (right):

https://codereview.chromium.org/2779833002/diff/1/tools/gn/xcode_writer.cc#ne...
tools/gn/xcode_writer.cc:543: // Add corresponding application target as
depedency of xctest module target
depedency -> dependency

[liaoyuke, 2017-03-28 15:49:05]

The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run

[liaoyuke, 2017-03-28 15:49:22]

Thank you very much for reviewing!

https://codereview.chromium.org/2779833002/diff/1/tools/gn/xcode_writer.cc
File tools/gn/xcode_writer.cc (right):

https://codereview.chromium.org/2779833002/diff/1/tools/gn/xcode_writer.cc#ne...
tools/gn/xcode_writer.cc:543: // Add corresponding application target as
depedency of xctest module target
On 2017/03/28 14:19:33, sdefresne wrote:
> depedency -> dependency

Done.

[commit-bot: I haz the power, 2017-03-28 15:49:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liaoyuke, 2017-03-28 15:50:00]

liaoyuke@chromium.org changed reviewers:
+ dpranke@chromium.org

[liaoyuke, 2017-03-28 15:50:45]

Hey Dirk,

Could you please take a look for owner's approval?

Thanks!

[commit-bot: I haz the power, 2017-03-28 16:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:01:12]

Dry run: This issue passed the CQ dry run.

[liaoyuke, 2017-03-29 16:19:02]

liaoyuke@chromium.org changed reviewers:
+ brettw@chromium.org

[liaoyuke, 2017-03-29 16:24:02]

liaoyuke@chromium.org changed reviewers:
- brettw@chromium.org

[liaoyuke, 2017-03-29 16:25:16]

liaoyuke@chromium.org changed reviewers:
+ brettw@chromium.org

[liaoyuke, 2017-03-29 16:27:40]

It seems that Dirk won't be available until 30th.

Brett, could you please take a quick look for owner's approval?

Thanks a lot!

[brettw, 2017-03-30 16:46:22]

owners lgtm based on sdefresne's review.

[liaoyuke, 2017-03-30 16:52:48]

On 2017/03/30 16:46:22, brettw (plz ping after 24h) wrote:
> owners lgtm based on sdefresne's review.

thanks a lot!

[liaoyuke, 2017-03-30 16:52:51]

The CQ bit was checked by liaoyuke@chromium.org

[liaoyuke, 2017-03-30 16:52:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2779833002/#ps20001
(title: "Update comments")

[commit-bot: I haz the power, 2017-03-30 16:53:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 17:13:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490892771783850,
"parent_rev": "41c4eadc12020d69f546b839fb64a29d00e591f8", "commit_rev":
"611254763b178dd9a1680e1e107a09aefb1267cb"}

[commit-bot: I haz the power, 2017-03-30 17:14:37]

Description was changed from

==========
[iOS] Add application target as dependency of xctest module target.

Previously, clicking on the "Play" button near a test in the test
navigator doesn't automatically re-build the application target, so that
tests don't test the current state of the code, but the one when it was
last compiled.

This CL fixes the problem by adding corresponding application target as
a dependency of xctest module target.

BUG=705005
==========

to

==========
[iOS] Add application target as dependency of xctest module target.

Previously, clicking on the "Play" button near a test in the test
navigator doesn't automatically re-build the application target, so that
tests don't test the current state of the code, but the one when it was
last compiled.

This CL fixes the problem by adding corresponding application target as
a dependency of xctest module target.

BUG=705005

Review-Url: https://codereview.chromium.org/2779833002
Cr-Commit-Position: refs/heads/master@{#460805}
Committed:
https://chromium.googlesource.com/chromium/src/+/611254763b178dd9a1680e1e107a...
==========

[commit-bot: I haz the power, 2017-03-30 17:14:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/611254763b178dd9a1680e1e107a...