Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2779783002: [Offline Pages] Add UMA to record final offline request status and loading failed error code. (Closed)

Created:
3 years, 9 months ago by Pete Williamson
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Add UMA to record final offline request status and loading failed error code. BUG=704999 Review-Url: https://codereview.chromium.org/2751253004 Cr-Commit-Position: refs/heads/master@{#458001} (cherry picked from commit 642d1848697b731de396d6df1577443e33e17ad0) Review-Url: https://codereview.chromium.org/2779783002 . Cr-Commit-Position: refs/branch-heads/3029@{#433} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -16 lines) Patch
M chrome/browser/android/offline_pages/background_loader_offliner.cc View 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.cc View 3 chunks +23 lines, -1 line 0 comments Download
M components/offline_pages/core/background/request_coordinator_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/request_notifier.h View 1 chunk +13 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
3 years, 9 months ago (2017-03-27 18:36:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd.

Powered by Google App Engine
This is Rietveld 408576698