Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2779763005: Reset stream if HTTP/2 response status is invalid. (Closed)

Created:
3 years, 8 months ago by Bence
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset stream if HTTP/2 response status is invalid. * Reset stream if HTTP/2 response ":status" header is missing, does not start with a number, or has extra text after the number. * Modify unittests to document behavior. * Obsolete histogram. This is mostly a revert of https://crrev.com/2555183002. BUG=672065 Review-Url: https://codereview.chromium.org/2779763005 Cr-Commit-Position: refs/heads/master@{#460644} Committed: https://chromium.googlesource.com/chromium/src/+/4ce14962179e9a25fdaaa595fc0cb093f79f4b79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -56 lines) Patch
M net/spdy/spdy_stream.cc View 3 chunks +15 lines, -49 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 4 chunks +60 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Bence
Ryan: PTAL. Thank you.
3 years, 8 months ago (2017-03-28 17:45:22 UTC) #5
Ryan Hamilton
lgtm
3 years, 8 months ago (2017-03-28 21:17:00 UTC) #8
Bence
Ilya: PTAL at tools/metrics/histograms/. Thank you.
3 years, 8 months ago (2017-03-29 13:00:41 UTC) #12
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-03-29 22:06:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779763005/1
3 years, 8 months ago (2017-03-30 00:52:11 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:31:52 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ce14962179e9a25fdaaa595fc0c...

Powered by Google App Engine
This is Rietveld 408576698