content/renderer/service_worker/embedded_worker_instance_client_impl.h - Issue 2779763004: Create ServiceWorkerProviderHost before starting worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.h

Issue 2779763004: Create ServiceWorkerProviderHost before starting worker (Closed)

Patch Set: Pass the param of BindWithProviderInfo by value instead of pointer Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_types.typemap ('k') | content/renderer/service_worker/embedded_worker_instance_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_instance_client_impl.h

diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.h b/content/renderer/service_worker/embedded_worker_instance_client_impl.h

index 097f32f26bbd2d19b845e9f5367bce1ff643d86e..29a07c552060853378ccd18a3a330ea1405269c7 100644

--- a/content/renderer/service_worker/embedded_worker_instance_client_impl.h

+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.h

@@ -73,8 +73,8 @@ class EmbeddedWorkerInstanceClientImpl

void StartWorker(

const EmbeddedWorkerStartParams& params,

mojom::ServiceWorkerEventDispatcherRequest dispatcher_request,

- mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo instance_host)

- override;

+ mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo instance_host,

+ mojom::ServiceWorkerProviderInfoForStartWorkerPtr provider_info) override;

void StopWorker() override;

void ResumeAfterDownload() override;

void AddMessageToConsole(blink::WebConsoleMessage::Level level,