Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3010)

Unified Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.cc

Issue 2779763004: Create ServiceWorkerProviderHost before starting worker (Closed)
Patch Set: Pass the param of BindWithProviderInfo by value instead of pointer Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/embedded_worker_instance_client_impl.cc
diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
index 424077104e1c97fff709306235cf1bd04356c2d5..580cc6712dc9edc12df5de14418a027e086270b2 100644
--- a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
@@ -54,7 +54,8 @@ void EmbeddedWorkerInstanceClientImpl::WorkerContextDestroyed() {
void EmbeddedWorkerInstanceClientImpl::StartWorker(
const EmbeddedWorkerStartParams& params,
mojom::ServiceWorkerEventDispatcherRequest dispatcher_request,
- mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo instance_host) {
+ mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo instance_host,
+ mojom::ServiceWorkerProviderInfoForStartWorkerPtr provider_info) {
DCHECK(ChildThreadImpl::current());
DCHECK(!wrapper_);
DCHECK(!stop_worker_time_.has_value());
@@ -62,11 +63,11 @@ void EmbeddedWorkerInstanceClientImpl::StartWorker(
"EmbeddedWorkerInstanceClientImpl::StartWorker");
wrapper_ = StartWorkerContext(
- params,
- base::MakeUnique<ServiceWorkerContextClient>(
- params.embedded_worker_id, params.service_worker_version_id,
- params.scope, params.script_url, std::move(dispatcher_request),
- std::move(instance_host), std::move(temporal_self_)));
+ params, base::MakeUnique<ServiceWorkerContextClient>(
+ params.embedded_worker_id, params.service_worker_version_id,
+ params.scope, params.script_url,
+ std::move(dispatcher_request), std::move(instance_host),
+ std::move(provider_info), std::move(temporal_self_)));
}
void EmbeddedWorkerInstanceClientImpl::StopWorker() {

Powered by Google App Engine
This is Rietveld 408576698