Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: ui/compositor/compositor_observer.h

Issue 2779753008: Make CompositorObserver’s destructor protected-and-virtual.
Patch Set: Fix compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/compositor_observer.h
diff --git a/ui/compositor/compositor_observer.h b/ui/compositor/compositor_observer.h
index d5f3371f5a734a3b1bf4eaf2b087fe46a46c5035..f833a5ae5c12cc8349b8b48193b443f853e2fcb1 100644
--- a/ui/compositor/compositor_observer.h
+++ b/ui/compositor/compositor_observer.h
@@ -38,6 +38,9 @@ class COMPOSITOR_EXPORT CompositorObserver {
// Called at the top of the compositor's destructor, to give observers a
// chance to remove themselves.
virtual void OnCompositingShuttingDown(Compositor* compositor) = 0;
+
+ protected:
danakj 2017/03/29 21:35:49 Can you please make it public though?
+ virtual ~CompositorObserver() {}
};
} // namespace ui
« no previous file with comments | « content/browser/renderer_host/browser_compositor_view_mac.mm ('k') | ui/compositor/test/draw_waiter_for_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698