ui/compositor/compositor_observer.h - Issue 2779753008: Make CompositorObserver’s destructor protected-and-virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/compositor/compositor_observer.h

Issue 2779753008: Make CompositorObserver’s destructor protected-and-virtual.

Patch Set: Fix compilation Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/renderer_host/browser_compositor_view_mac.mm ('k') | ui/compositor/test/draw_waiter_for_test.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_	5 #ifndef UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_

6 #define UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_	6 #define UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_

7	7

8 #include "base/time/time.h"	8 #include "base/time/time.h"

9 #include "ui/compositor/compositor_export.h"	9 #include "ui/compositor/compositor_export.h"

10	10

(...skipping 20 matching lines...) Expand all Loading...
31	31

32 // Called when compositing completes: the present to screen has completed.	32 // Called when compositing completes: the present to screen has completed.

33 virtual void OnCompositingEnded(Compositor* compositor) = 0;	33 virtual void OnCompositingEnded(Compositor* compositor) = 0;

34	34

35 // Called when the compositor lock state changes.	35 // Called when the compositor lock state changes.

36 virtual void OnCompositingLockStateChanged(Compositor* compositor) = 0;	36 virtual void OnCompositingLockStateChanged(Compositor* compositor) = 0;

37	37

38 // Called at the top of the compositor's destructor, to give observers a	38 // Called at the top of the compositor's destructor, to give observers a

39 // chance to remove themselves.	39 // chance to remove themselves.

40 virtual void OnCompositingShuttingDown(Compositor* compositor) = 0;	40 virtual void OnCompositingShuttingDown(Compositor* compositor) = 0;

	41

	42 protected:
	danakj 2017/03/29 21:35:49 Can you please make it public though? Can you please make it public though?
	43 virtual ~CompositorObserver() {}

41 };	44 };

42	45

43 } // namespace ui	46 } // namespace ui

44	47

45 #endif // UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_	48 #endif // UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_

OLD	NEW