Make CompositorObserver’s destructor protected-and-virtual.

Make CompositorObserver’s destructor protected-and-virtual.

Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None

[neptr, 2017-03-29 14:10:01]

Description was changed from

==========
# Enter a description of the change.
Make CompositorObserver’s destructor protected-and-virtual.

Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

to

==========
Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

[neptr, 2017-03-29 14:10:01]

neptr@yandex-team.ru changed reviewers:
+ danakj@chromium.org

[neptr, 2017-03-29 14:10:21]

Description was changed from

==========
Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

to

==========
Make CompositorObserver’s destructor protected-and-virtual.

Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

[danakj, 2017-03-29 14:12:34]

virtual is good. I don't understand the protected part. LGTM but I'd rather it's
public.

[neptr, 2017-03-29 14:14:07]

On 2017/03/29 14:12:34, danakj wrote:
> virtual is good. I don't understand the protected part. LGTM but I'd rather
it's
> public.

All other observers are protected, so it seems more safe unless it breaks
compilation (which was fine locally).

[neptr, 2017-03-29 14:14:11]

The CQ bit was checked by neptr@yandex-team.ru

[commit-bot: I haz the power, 2017-03-29 14:14:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 14:14:25]

The author neptr@yandex-team.ru has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[danakj, 2017-03-29 14:20:08]

On 2017/03/29 14:14:07, neptr wrote:
> On 2017/03/29 14:12:34, danakj wrote:
> > virtual is good. I don't understand the protected part. LGTM but I'd rather
> it's
> > public.
> 
> All other observers are protected, so it seems more safe unless it breaks
> compilation (which was fine locally).

I don't think it's more safe. It's fine if someone wants to delete the object by
the base class, it imposes unneeded restrictions on other code.

[neptr, 2017-03-29 14:48:13]

The CQ bit was checked by neptr@yandex-team.ru

[commit-bot: I haz the power, 2017-03-29 14:48:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 14:59:42]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[neptr, 2017-03-29 15:16:18]

The CQ bit was checked by neptr@yandex-team.ru

[neptr, 2017-03-29 15:16:18]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2779753008/#ps20001
(title: "Fix compilation")

[commit-bot: I haz the power, 2017-03-29 15:17:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neptr, 2017-03-29 15:37:09]

The CQ bit was checked by neptr@yandex-team.ru

[neptr, 2017-03-29 15:37:10]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2779753008/#ps40001
(title: "Fix compilation")

[commit-bot: I haz the power, 2017-03-29 15:37:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neptr, 2017-03-29 15:39:34]

neptr@yandex-team.ru changed reviewers:
+ ccameron@chromium.org

[neptr, 2017-03-29 15:40:22]

Added ccameron to review the browser_compositor_view_mac.mm.

[commit-bot: I haz the power, 2017-03-29 15:47:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:47:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ccameron, 2017-03-29 20:56:23]

.mm lgtm

[danakj, 2017-03-29 21:35:49]

https://codereview.chromium.org/2779753008/diff/40001/ui/compositor/composito...
File ui/compositor/compositor_observer.h (right):

https://codereview.chromium.org/2779753008/diff/40001/ui/compositor/composito...
ui/compositor/compositor_observer.h:42: protected:
Can you please make it public though?

[themblsha, 2017-03-30 12:53:27]

On 2017/03/29 21:35:49, danakj wrote:
>
https://codereview.chromium.org/2779753008/diff/40001/ui/compositor/composito...
> ui/compositor/compositor_observer.h:42: protected:
> Can you please make it public though?

Done!

[neptr, 2017-03-30 12:53:56]

The CQ bit was checked by neptr@yandex-team.ru

[neptr, 2017-03-30 12:53:56]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2779753008/#ps80001
(title: "Rebase on top of recent master to remove unwanted changes.")

[commit-bot: I haz the power, 2017-03-30 12:54:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 12:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 12:54:21]

The author neptr@yandex-team.ru has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.