third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js - Issue 2779703004: DevTools: carefully cleanup CSS sourcemaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js

Issue 2779703004: DevTools: carefully cleanup CSS sourcemaps (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js ('K') | « third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js

index b6ab08ac745cd0998dd7e1ad1ea4128e44ad59ed..93eb82fe0b24192ae68aacc1c79936e6244674be 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js

@@ -220,9 +220,10 @@ SDK.SourceMapManager = class extends SDK.SDKObject {

return;

}

this._sourceMapURLToClients.remove(sourceMapURL, client);

+ var sourceMap = this._sourceMapByURL.get(sourceMapURL);

if (!this._sourceMapURLToClients.has(sourceMapURL))

this._sourceMapByURL.delete(sourceMapURL);

- this.dispatchEventToListeners(SDK.SourceMapManager.Events.SourceMapDetached, client);

+ this.dispatchEventToListeners(SDK.SourceMapManager.Events.SourceMapDetached, {client, sourceMap});

lushnikov 2017/03/28 01:39:32 used "shorthand property names" here :)

dgozman 2017/03/28 23:37:37 Scary! Maybe trial this feature in tests first?

lushnikov 2017/03/29 01:27:24 Done.

}

_sourceMapLoadedForTest() {