Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2779703004: DevTools: carefully cleanup CSS sourcemaps (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: carefully cleanup CSS sourcemaps This patch starts to cleanup CSS sourcemaps as they get detached from host stylesheets. BUG=670180 R=dgozman Review-Url: https://codereview.chromium.org/2779703004 Cr-Commit-Position: refs/heads/master@{#460596} Committed: https://chromium.googlesource.com/chromium/src/+/314a2aec9a9f1b4de5be0a4c215a4f7c73da1d87

Patch Set 1 #

Total comments: 7

Patch Set 2 : address comments #

Patch Set 3 : fix tests #

Messages

Total messages: 18 (12 generated)
lushnikov
please, take a look https://codereview.chromium.org/2779703004/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js File third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js (right): https://codereview.chromium.org/2779703004/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js#newcode226 third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js:226: this.dispatchEventToListeners(SDK.SourceMapManager.Events.SourceMapDetached, {client, sourceMap}); used "shorthand ...
3 years, 9 months ago (2017-03-28 01:39:32 UTC) #1
dgozman
https://codereview.chromium.org/2779703004/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js (right): https://codereview.chromium.org/2779703004/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js#newcode72 third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js:72: return; I haven't seen any difference in tests related ...
3 years, 8 months ago (2017-03-28 23:37:37 UTC) #6
lushnikov
https://codereview.chromium.org/2779703004/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js (right): https://codereview.chromium.org/2779703004/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js#newcode72 third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js:72: return; On 2017/03/28 23:37:37, dgozman wrote: > I haven't ...
3 years, 8 months ago (2017-03-29 01:27:24 UTC) #7
dgozman
lgtm
3 years, 8 months ago (2017-03-29 21:07:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779703004/40001
3 years, 8 months ago (2017-03-29 22:26:28 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 00:26:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/314a2aec9a9f1b4de5be0a4c215a...

Powered by Google App Engine
This is Rietveld 408576698