Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2779653003: WindowTreeHostManager::GetRootWindowForDisplayId -> WmShell::GetRoo... (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, je_julie, aboxhall+watch_chromium.org, nektar+watch_chromium.org, dcheng, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WindowTreeHostManager::GetRootWindowForDisplayId -> WmShell::GetRoo... WindowTreeHostManager isn't used in mus/mash where as WmShell always works. BUG=704985 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2779653003 Cr-Commit-Position: refs/heads/master@{#459943} Committed: https://chromium.googlesource.com/chromium/src/+/fdef0a41cb0137a12e40bad9bdf7f39e53a2d51b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -32 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/shell/window_watcher.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M ash/wm/drag_window_controller.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 9 months ago (2017-03-27 22:24:15 UTC) #1
msw
lgtm
3 years, 9 months ago (2017-03-27 22:29:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779653003/1
3 years, 9 months ago (2017-03-27 23:45:58 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 23:53:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdef0a41cb0137a12e40bad9bdf7...

Powered by Google App Engine
This is Rietveld 408576698