Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2779603002: Enable blocking of subresource requests whose URLs include credentials. (Closed)
Patch Set: Tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 068e5302b53cff9ce45ed0fae2223e734255b6da..2f62ff31a638e61653b0199050639fa904c56787 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -275,12 +275,10 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature) {
"https://www.chromestatus.com/feature/5709390967472128 for details.");
case UseCounter::RequestedSubresourceWithEmbeddedCredentials:
- return String::format(
- "Subresource requests whose URLs contain embedded credentials (e.g. "
- "`https://user:pass@host/`) are deprecated, and will be blocked in "
- "%s. See https://www.chromestatus.com/feature/5669008342777856 for "
- "more details.",
- milestoneString(M59));
+ return "Subresource requests whose URLs contain embedded credentials "
+ "(e.g. `https://user:pass@host/`) are blocked. See "
+ "https://www.chromestatus.com/feature/5669008342777856 for more "
+ "details.";
// Powerful features on insecure origins (https://goo.gl/rStTGz)
case UseCounter::DeviceMotionInsecureOrigin:

Powered by Google App Engine
This is Rietveld 408576698