Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2779603002: Enable blocking of subresource requests whose URLs include credentials. (Closed)
Patch Set: Tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 268
269 // Blocked subresource requests: 269 // Blocked subresource requests:
270 case UseCounter::LegacyProtocolEmbeddedAsSubresource: 270 case UseCounter::LegacyProtocolEmbeddedAsSubresource:
271 return String::format( 271 return String::format(
272 "Subresource requests using legacy protocols (like `ftp:`) are " 272 "Subresource requests using legacy protocols (like `ftp:`) are "
273 "are blocked. Please deliver web-accessible resources over modern " 273 "are blocked. Please deliver web-accessible resources over modern "
274 "protocols like HTTPS. See " 274 "protocols like HTTPS. See "
275 "https://www.chromestatus.com/feature/5709390967472128 for details."); 275 "https://www.chromestatus.com/feature/5709390967472128 for details.");
276 276
277 case UseCounter::RequestedSubresourceWithEmbeddedCredentials: 277 case UseCounter::RequestedSubresourceWithEmbeddedCredentials:
278 return String::format( 278 return "Subresource requests whose URLs contain embedded credentials "
279 "Subresource requests whose URLs contain embedded credentials (e.g. " 279 "(e.g. `https://user:pass@host/`) are blocked. See "
280 "`https://user:pass@host/`) are deprecated, and will be blocked in " 280 "https://www.chromestatus.com/feature/5669008342777856 for more "
281 "%s. See https://www.chromestatus.com/feature/5669008342777856 for " 281 "details.";
282 "more details.",
283 milestoneString(M59));
284 282
285 // Powerful features on insecure origins (https://goo.gl/rStTGz) 283 // Powerful features on insecure origins (https://goo.gl/rStTGz)
286 case UseCounter::DeviceMotionInsecureOrigin: 284 case UseCounter::DeviceMotionInsecureOrigin:
287 return "The devicemotion event is deprecated on insecure origins, and " 285 return "The devicemotion event is deprecated on insecure origins, and "
288 "support will be removed in the future. You should consider " 286 "support will be removed in the future. You should consider "
289 "switching your application to a secure origin, such as HTTPS. " 287 "switching your application to a secure origin, such as HTTPS. "
290 "See https://goo.gl/rStTGz for more details."; 288 "See https://goo.gl/rStTGz for more details.";
291 289
292 case UseCounter::DeviceOrientationInsecureOrigin: 290 case UseCounter::DeviceOrientationInsecureOrigin:
293 return "The deviceorientation event is deprecated on insecure origins, " 291 return "The deviceorientation event is deprecated on insecure origins, "
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 "the 'script-src' directive for Workers", 426 "the 'script-src' directive for Workers",
429 M60, "5922594955984896"); 427 M60, "5922594955984896");
430 428
431 // Features that aren't deprecated don't have a deprecation message. 429 // Features that aren't deprecated don't have a deprecation message.
432 default: 430 default:
433 return String(); 431 return String();
434 } 432 }
435 } 433 }
436 434
437 } // namespace blink 435 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698