Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2779593003: [Android Tests] Preload Calendar to avoid StrictMode violations (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
CC:
chromium-reviews, the real yoland
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android Tests] Preload Calendar to avoid StrictMode violations In instrumentation tests Calendar#getInstance can trigger ReadFromDisk StrictMode violations when it needs to read system files to obtain the time zone, which make tests fail. This patch preloads Calendar to avoid it happening later on the UI Thread and avoid these flakes. BUG=705477 Review-Url: https://codereview.chromium.org/2779593003 Cr-Commit-Position: refs/heads/master@{#459798} Committed: https://chromium.googlesource.com/chromium/src/+/f51dc18c55c7af0bac195c1b507398c5f408f0bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgn
PTAL Note: I could not repro the strict mode violation locally, even when removing the ...
3 years, 9 months ago (2017-03-27 12:59:54 UTC) #2
Bernhard Bauer
lgtm
3 years, 9 months ago (2017-03-27 13:41:45 UTC) #7
jbudorick
lgtm +cc yolandyan: fyi for junit4 conversions
3 years, 9 months ago (2017-03-27 15:55:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779593003/1
3 years, 9 months ago (2017-03-27 16:07:08 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 16:25:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f51dc18c55c7af0bac195c1b5073...

Powered by Google App Engine
This is Rietveld 408576698