Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2779543004: Follow up to empty text header (Closed)

Created:
3 years, 9 months ago by JJ
Modified:
3 years, 9 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow up to empty text header I quite literally don't know how this went through as I checked my other branch and it had this in. So I'm a little confused on what happened as I'm 100% sure I did a cl upload. Regardless this silently went in and as a result this is a quick way to fix it. BUG=705242 Review-Url: https://codereview.chromium.org/2779543004 Cr-Commit-Position: refs/heads/master@{#459888} Committed: https://chromium.googlesource.com/chromium/src/+/3bb5696626414f0b955c9dedb8552fe8df09cb26

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (4 generated)
JJ
I'm super sorry on this. It was fixed locally so I didn't see the change ...
3 years, 9 months ago (2017-03-27 20:23:04 UTC) #2
Ted C
lgtm https://codereview.chromium.org/2779543004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java (right): https://codereview.chromium.org/2779543004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java#newcode35 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java:35: if (!TextUtils.isEmpty(headerText)) { :-P
3 years, 9 months ago (2017-03-27 20:23:47 UTC) #3
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-03-27 20:23:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779543004/1
3 years, 9 months ago (2017-03-27 20:25:24 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:37:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bb5696626414f0b955c9dedb855...

Powered by Google App Engine
This is Rietveld 408576698