Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2779523005: [Autofill] Clean up TODO. (Closed)

Created:
3 years, 8 months ago by jiahuiguo
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up TODO. We won't be investigating this path. BUG=676164 TBR=estade Review-Url: https://codereview.chromium.org/2779523005 Cr-Commit-Position: refs/heads/master@{#460499} Committed: https://chromium.googlesource.com/chromium/src/+/d0fca10eff7508cf86c231af8dfee0da3609b677

Patch Set 1 : Clean up the won't fix bug TODO in the codebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/views/autofill/autofill_popup_base_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
jiahuiguo
Hi Mathieu, PTAL.
3 years, 8 months ago (2017-03-29 01:16:45 UTC) #2
Mathieu
lgtm
3 years, 8 months ago (2017-03-29 13:41:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779523005/1
3 years, 8 months ago (2017-03-29 13:41:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/397484)
3 years, 8 months ago (2017-03-29 13:49:42 UTC) #8
jiahuiguo
Hi Even, needs your approval.
3 years, 8 months ago (2017-03-29 18:12:44 UTC) #11
jiahuiguo
On 2017/03/29 18:12:44, jiahuiguo wrote: > Hi Even, needs your approval. Sorry, Evan.
3 years, 8 months ago (2017-03-29 18:13:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779523005/1
3 years, 8 months ago (2017-03-29 19:08:18 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:47:30 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0fca10eff7508cf86c231af8dfe...

Powered by Google App Engine
This is Rietveld 408576698