Chrome OS: Fix taking user pictures to be used as user POD images.

Chrome OS: Fix taking user pictures to be used as user POD images.


This CL fixes taking camera photos when creating new user.
This has been broken since https://crbug.com/596786 .

BUG=701700
Review-Url: https://codereview.chromium.org/2779463002
Cr-Commit-Position: refs/heads/master@{#460654}
Committed: https://chromium.googlesource.com/chromium/src/+/206c4eb900a3221d9abaf5904ddcb672453cfd6b

[Alexander Alekseev, 2017-03-25 09:07:38]

alemate@chromium.org changed reviewers:
+ achuith@chromium.org, jyasskin@chromium.org, raymes@chromium.org,
sergeyu@chromium.org, timloh@chromium.org

[Alexander Alekseev, 2017-03-25 09:07:39]

ChromeOS login camera permissions are broken (presumably in
https://codereview.chromium.org/2696703006 ).

This Cl fixes the ability to take picture when creating new user. This should
work for all user types (supervised, normal, AD, whatever).

I tried to use ContentSettingsPattern instead of plain text, but it doesn't seem
to support 'chrome://oobe/' types of URLS.


Adding authors and reviewers of the original CL.

Please review.

[achuithb, 2017-03-27 17:35:35]

lgtm. Looks like the CL author is OOO at the moment, so feel free to land

[Alexander Alekseev, 2017-03-29 00:04:23]

sergeyu@
tommi@

Friendly ping for chrome/browser/media/webrtc/ .

[Alexander Alekseev, 2017-03-29 00:05:17]

alemate@chromium.org changed reviewers:
+ tommi@webrtc.org

[Alexander Alekseev, 2017-03-29 00:05:17]

sergeyu@chromium.org
tommi@chromium.org

Please review chrome/browser/media/webrtc/
(We need this for M58)

[Sergey Ulanov, 2017-03-29 23:26:18]

If I understand correctly this got broken by
https://codereview.chromium.org/2706813004 . How did it work before? How is this
related to the kLoginVideoCaptureAllowedUrls? It would be best to clarify it in
the CL description. 

LGTM once my comments are addressed.

https://codereview.chromium.org/2779463002/diff/1/chrome/browser/media/webrtc...
File chrome/browser/media/webrtc/media_permission.cc (right):

https://codereview.chromium.org/2779463002/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/media_permission.cc:74: constexpr char pattern[] =
"chrome://oobe/";
Use kChromeUIOobeURL from chrome/common/url_constants.h here?
If it can't be used here then this const should have a const-style name, also
it's an origin, not a pattern (kOobeOrigin would be a better name).

https://codereview.chromium.org/2779463002/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/media_permission.cc:75: if
(requesting_origin_.possibly_invalid_spec() == pattern) {
use spec() instead of possibly_invalid_spec() here?

[Alexander Alekseev, 2017-03-30 02:04:34]

https://codereview.chromium.org/2779463002/diff/1/chrome/browser/media/webrtc...
File chrome/browser/media/webrtc/media_permission.cc (right):

https://codereview.chromium.org/2779463002/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/media_permission.cc:74: constexpr char pattern[] =
"chrome://oobe/";
On 2017/03/29 23:26:17, Sergey Ulanov wrote:
> Use kChromeUIOobeURL from chrome/common/url_constants.h here?
> If it can't be used here then this const should have a const-style name, also
> it's an origin, not a pattern (kOobeOrigin would be a better name).

Done.

https://codereview.chromium.org/2779463002/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/media_permission.cc:75: if
(requesting_origin_.possibly_invalid_spec() == pattern) {
On 2017/03/29 23:26:17, Sergey Ulanov wrote:
> use spec() instead of possibly_invalid_spec() here?

Done.

[Alexander Alekseev, 2017-03-30 02:04:40]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2017-03-30 02:04:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2779463002/#ps20001
(title: "Update after review.")

[commit-bot: I haz the power, 2017-03-30 02:05:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 03:55:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490839480824800,
"parent_rev": "bfe0492224665ab6ce8dd8588dcfb474fb27fdbe", "commit_rev":
"206c4eb900a3221d9abaf5904ddcb672453cfd6b"}

[commit-bot: I haz the power, 2017-03-30 03:56:40]

Description was changed from

==========
Chrome OS: Fix taking user pictures to be used as user POD images.


This CL fixes taking camera photos when creating new user.
This has been broken since https://crbug.com/596786 .

BUG=701700
==========

to

==========
Chrome OS: Fix taking user pictures to be used as user POD images.


This CL fixes taking camera photos when creating new user.
This has been broken since https://crbug.com/596786 .

BUG=701700

Review-Url: https://codereview.chromium.org/2779463002
Cr-Commit-Position: refs/heads/master@{#460654}
Committed:
https://chromium.googlesource.com/chromium/src/+/206c4eb900a3221d9abaf5904ddc...
==========

[commit-bot: I haz the power, 2017-03-30 03:56:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/206c4eb900a3221d9abaf5904ddc...