[Payments] Return the preferred payment method name to the merchant

[Payments] Return the preferred payment method name to the merchant

In the PaymentResponse, the method_name field can vary between
"basic-card" and the card network directly (e.g., "visa"), depending
where the network was first specified.

BUG=701952
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2779453002
Cr-Commit-Position: refs/heads/master@{#459671}
Committed: https://chromium.googlesource.com/chromium/src/+/600bab5603e925b489b69a83d3d4eb7170a2e649

[Mathieu, 2017-03-25 02:28:59]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[Mathieu, 2017-03-25 02:29:00]

Rouslan, PTAL!

[please use gerrit instead, 2017-03-25 17:07:33]

https://codereview.chromium.org/2779453002/diff/1/components/payments/content...
File components/payments/content/payment_request_state_unittest.cc (right):

https://codereview.chromium.org/2779453002/diff/1/components/payments/content...
components/payments/content/payment_request_state_unittest.cc:324:
EXPECT_EQ(kBasicCardMethodName, response()->method_name);
Let's use "basic-card" here, similar to line 311.

[please use gerrit instead, 2017-03-25 17:07:39]

lgtm

[Mathieu, 2017-03-25 20:27:25]

Done

https://codereview.chromium.org/2779453002/diff/1/components/payments/content...
File components/payments/content/payment_request_state_unittest.cc (right):

https://codereview.chromium.org/2779453002/diff/1/components/payments/content...
components/payments/content/payment_request_state_unittest.cc:324:
EXPECT_EQ(kBasicCardMethodName, response()->method_name);
On 2017/03/25 17:07:33, ಠ_ಠ slow - w3c wrote:
> Let's use "basic-card" here, similar to line 311.

Done.

[Mathieu, 2017-03-25 20:27:28]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-03-25 20:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2779453002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-25 20:27:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 20:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 20:56:29]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Mathieu, 2017-03-26 00:31:07]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-03-26 00:31:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2779453002/#ps40001
(title: "compile fix")

[commit-bot: I haz the power, 2017-03-26 00:31:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 01:35:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 01:35:24]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-03-26 01:43:19]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-03-26 01:43:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 03:48:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490492599553900,
"parent_rev": "8318c659370c46679a96d84b5735a708110c53fd", "commit_rev":
"600bab5603e925b489b69a83d3d4eb7170a2e649"}

[commit-bot: I haz the power, 2017-03-26 03:48:48]

Description was changed from

==========
[Payments] Return the preferred payment method name to the merchant

In the PaymentResponse, the method_name field can vary between
"basic-card" and the card network directly (e.g., "visa"), depending
where the network was first specified.

BUG=701952
TEST=components_unittests
==========

to

==========
[Payments] Return the preferred payment method name to the merchant

In the PaymentResponse, the method_name field can vary between
"basic-card" and the card network directly (e.g., "visa"), depending
where the network was first specified.

BUG=701952
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2779453002
Cr-Commit-Position: refs/heads/master@{#459671}
Committed:
https://chromium.googlesource.com/chromium/src/+/600bab5603e925b489b69a83d3d4...
==========

[commit-bot: I haz the power, 2017-03-26 03:48:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/600bab5603e925b489b69a83d3d4...