Fix nullptr deref in ChildThreadImpl

Fix nullptr deref in ChildThreadImpl

It's possible that a child process has no Service Manager connection. This
avoids dereferencing a null |service_manager_connection_| in that case.

BUG=705175, 704747
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2779443002
Cr-Commit-Position: refs/heads/master@{#459634}
Committed: https://chromium.googlesource.com/chromium/src/+/7844edf8040581364b3651ac6e0f4ddbc27efe9a

[Ken Rockot(use gerrit already), 2017-03-25 01:43:34]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 01:44:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-25 01:44:20]

Description was changed from

==========
Fix nullptr deref in ChildThreadImpl

It's possible that child process has no Service Manager connection, in
which case ChildThreadImpl::GetConnector() is null. This adds a check to
avoid dereferencing it in that case.

BUG=705175,70474
==========

to

==========
Fix nullptr deref in ChildThreadImpl

It's possible that child process has no Service Manager connection, in
which case ChildThreadImpl::GetConnector() is null. This adds a check to
avoid dereferencing it in that case.

BUG=705175,70474
TBR=ben@chromium.org
==========

[Lei Zhang, 2017-03-25 01:50:50]

70474 -> 704747 BTW

[Ken Rockot(use gerrit already), 2017-03-25 01:51:50]

Description was changed from

==========
Fix nullptr deref in ChildThreadImpl

It's possible that child process has no Service Manager connection, in
which case ChildThreadImpl::GetConnector() is null. This adds a check to
avoid dereferencing it in that case.

BUG=705175,70474
TBR=ben@chromium.org
==========

to

==========
Fix nullptr deref in ChildThreadImpl

It's possible that child process has no Service Manager connection, in
which case ChildThreadImpl::GetConnector() is null. This adds a check to
avoid dereferencing it in that case.

BUG=705175,704747
TBR=ben@chromium.org
==========

[Ken Rockot(use gerrit already), 2017-03-25 01:52:11]

Thanks. Fixing reeeeally old bugs.

[Ken Rockot(use gerrit already), 2017-03-25 01:54:01]

Description was changed from

==========
Fix nullptr deref in ChildThreadImpl

It's possible that child process has no Service Manager connection, in
which case ChildThreadImpl::GetConnector() is null. This adds a check to
avoid dereferencing it in that case.

BUG=705175,704747
TBR=ben@chromium.org
==========

to

==========
Fix nullptr deref in ChildThreadImpl

It's possible that a child process has no Service Manager connection, in
which case ChildThreadImpl::GetConnector() is null. This adds a check to
avoid dereferencing it in that case.

BUG=705175,704747
TBR=ben@chromium.org
==========

[Lei Zhang, 2017-03-25 01:56:33]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-03-25 01:56:34]

https://codereview.chromium.org/2779443002/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/2779443002/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:506: if (GetConnector()) {
GetConnector() is service_manager_connection_->GetConnector() underneath. So
maybe |service_manager_connection_| is a nullptr? In which case, this won't be
affective.

You may be on the right track, because the code below on line 519 affected the
Cloud Print Connector as well.

[Ken Rockot(use gerrit already), 2017-03-25 02:02:03]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 02:02:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-25 02:02:48]

And that's what I get for TBRing...

https://codereview.chromium.org/2779443002/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/2779443002/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:506: if (GetConnector()) {
On 2017/03/25 at 01:56:34, Lei Zhang wrote:
> GetConnector() is service_manager_connection_->GetConnector() underneath. So
maybe |service_manager_connection_| is a nullptr? In which case, this won't be
affective.
> 
> You may be on the right track, because the code below on line 519 affected the
Cloud Print Connector as well.

Thanks. Fixed. /shamecube

[Ken Rockot(use gerrit already), 2017-03-25 02:03:33]

Description was changed from

==========
Fix nullptr deref in ChildThreadImpl

It's possible that a child process has no Service Manager connection, in
which case ChildThreadImpl::GetConnector() is null. This adds a check to
avoid dereferencing it in that case.

BUG=705175,704747
TBR=ben@chromium.org
==========

to

==========
Fix nullptr deref in ChildThreadImpl

It's possible that a child process has no Service Manager connection. This
avoids dereferencing a null |service_manager_connection_| in that case.

BUG=705175,704747
TBR=ben@chromium.org
==========

[Lei Zhang, 2017-03-25 02:13:26]

Works for me, so LGTM

[commit-bot: I haz the power, 2017-03-25 02:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 02:56:34]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-03-25 02:59:26]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-03-25 02:59:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 03:04:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490410766338260,
"parent_rev": "2caede8adadec1174094eaea6b0014a578614eaf", "commit_rev":
"7844edf8040581364b3651ac6e0f4ddbc27efe9a"}

[commit-bot: I haz the power, 2017-03-25 03:05:53]

Description was changed from

==========
Fix nullptr deref in ChildThreadImpl

It's possible that a child process has no Service Manager connection. This
avoids dereferencing a null |service_manager_connection_| in that case.

BUG=705175,704747
TBR=ben@chromium.org
==========

to

==========
Fix nullptr deref in ChildThreadImpl

It's possible that a child process has no Service Manager connection. This
avoids dereferencing a null |service_manager_connection_| in that case.

BUG=705175,704747
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2779443002
Cr-Commit-Position: refs/heads/master@{#459634}
Committed:
https://chromium.googlesource.com/chromium/src/+/7844edf8040581364b3651ac6e0f...
==========

[commit-bot: I haz the power, 2017-03-25 03:05:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7844edf8040581364b3651ac6e0f...