Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2779393002: Add an include-paths only jpeg group (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, kjellander_chromium
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an include-paths only jpeg group Because libyuv switched to compiling with clang for win64 builds: https://chromium-review.googlesource.com/c/446667/ we ended up with libjpeg being compiled an additional time, also with clang. Having two copies is undesirable, so we need a way for libyuv to request the include paths for the appropriate version of libjpeg. This sets up a group that libyuv can use for that purpose. Getting libyuv to use this group is a separate change, in the libyuv repo. R=brettw@chromium.org BUG=706627 Review-Url: https://codereview.chromium.org/2779393002 Cr-Commit-Position: refs/heads/master@{#460889} Committed: https://chromium.googlesource.com/chromium/src/+/ae920018eb44986c5c9cdf16285361720dd0df59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
brucedawson
I've tested this with the corresponding libyuv change and it appears to work as intended ...
3 years, 8 months ago (2017-03-30 00:38:45 UTC) #3
brettw
lgtm
3 years, 8 months ago (2017-03-30 21:18:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779393002/1
3 years, 8 months ago (2017-03-30 21:25:10 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:39:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae920018eb44986c5c9cdf162853...

Powered by Google App Engine
This is Rietveld 408576698