Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2779373003: Moving service urls to base. (Closed)

Created:
3 years, 8 months ago by nicholss
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving service urls to base. BUG=699788 Review-Url: https://codereview.chromium.org/2779373003 Cr-Commit-Position: refs/heads/master@{#461246} Committed: https://chromium.googlesource.com/chromium/src/+/a36b97239e429ff829dd785fc8a3f9b5f7d145e9

Patch Set 1 #

Patch Set 2 : pnacl can't build net related calls. Removing service urls. #

Patch Set 3 : Had to breakout the remoting_bot file again, moved to base. #

Total comments: 2

Patch Set 4 : Updating moved file c dates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -232 lines) Patch
M remoting/base/BUILD.gn View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
A + remoting/base/remoting_bot.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/base/remoting_bot.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/base/service_urls.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/base/service_urls.cc View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +1 line, -1 line 0 comments Download
D remoting/host/service_urls.h View 1 chunk +0 lines, -69 lines 0 comments Download
D remoting/host/service_urls.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M remoting/host/setup/start_host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D remoting/signaling/remoting_bot.h View 1 chunk +0 lines, -25 lines 0 comments Download
D remoting/signaling/remoting_bot.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
nicholss
On 2017/03/29 23:27:25, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
3 years, 8 months ago (2017-03-29 23:40:21 UTC) #11
Sergey Ulanov
lgtm https://codereview.chromium.org/2779373003/diff/40001/remoting/base/service_urls.cc File remoting/base/service_urls.cc (right): https://codereview.chromium.org/2779373003/diff/40001/remoting/base/service_urls.cc#newcode1 remoting/base/service_urls.cc:1: // Copyright 2016 The Chromium Authors. All rights ...
3 years, 8 months ago (2017-03-31 18:38:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779373003/60001
3 years, 8 months ago (2017-03-31 20:51:48 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 22:13:23 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a36b97239e429ff829dd785fc8a3...

Powered by Google App Engine
This is Rietveld 408576698