token-server: Warmup some local caches in /_ah/warmup.

token-server: Warmup some local caches in /_ah/warmup.

Removes some datastore and memcache ops from first served request.

R=iannucci@chromium.org, nodir@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2779323002
Committed: https://github.com/luci/luci-go/commit/f8f69fd1d13eb65482aef7a11d42672a8bc6daad

[Vadim Sh., 2017-03-29 21:12:57]

PTAL

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
File tokenserver/appengine/impl/certconfig/ca.go (right):

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
tokenserver/appengine/impl/certconfig/ca.go:75: func ListCAs(c context.Context)
([]string, error) {
this is just moved from rpc_list_cas.go

[nodir, 2017-03-29 21:45:06]

lgtm

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
File tokenserver/appengine/impl/certchecker/warmup.go (right):

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
tokenserver/appengine/impl/certchecker/warmup.go:28:
logging.WithError(err).Warningf(c, "Failed to warm up %q", cn)
why it doesn't return err in this case but returns it @L19?

[Vadim Sh., 2017-03-29 21:49:30]

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
File tokenserver/appengine/impl/certchecker/warmup.go (right):

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
tokenserver/appengine/impl/certchecker/warmup.go:28:
logging.WithError(err).Warningf(c, "Failed to warm up %q", cn)
On 2017/03/29 21:45:06, nodir wrote:
> why it doesn't return err in this case but returns it @L19?

Because we don't want to do "return err" here, before checking all CAs, and I
didn't want to bother with MultiErrror handling :) Errors in warmup are not
really important.

[Vadim Sh., 2017-03-29 23:46:02]

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
File tokenserver/appengine/impl/certchecker/warmup.go (right):

https://codereview.chromium.org/2779323002/diff/1/tokenserver/appengine/impl/...
tokenserver/appengine/impl/certchecker/warmup.go:28:
logging.WithError(err).Warningf(c, "Failed to warm up %q", cn)
On 2017/03/29 21:49:30, Vadim Sh. wrote:
> On 2017/03/29 21:45:06, nodir wrote:
> > why it doesn't return err in this case but returns it @L19?
> 
> Because we don't want to do "return err" here, before checking all CAs, and I
> didn't want to bother with MultiErrror handling :) Errors in warmup are not
> really important.

Added MultiError.

[Vadim Sh., 2017-03-29 23:46:06]

The CQ bit was checked by vadimsh@chromium.org

[Vadim Sh., 2017-03-29 23:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2779323002/#ps20001
(title: "also warmup delegation config")

[commit-bot: I haz the power, 2017-03-29 23:46:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:51:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:51:26]

Try jobs failed on following builders:
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35354a9030defb10)

[Vadim Sh., 2017-03-29 23:58:12]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:58:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 00:06:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490831892103970,
"parent_rev": "530908a6c3d10f70895d64aceae79aef0cb9b50d", "commit_rev":
"f8f69fd1d13eb65482aef7a11d42672a8bc6daad"}

[commit-bot: I haz the power, 2017-03-30 00:06:09]

Description was changed from

==========
token-server: Warmup some local caches in /_ah/warmup.

Removes some datastore and memcache ops from first served request.

R=iannucci@chromium.org, nodir@chromium.org
BUG=
==========

to

==========
token-server: Warmup some local caches in /_ah/warmup.

Removes some datastore and memcache ops from first served request.

R=iannucci@chromium.org, nodir@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2779323002
Committed:
https://github.com/luci/luci-go/commit/f8f69fd1d13eb65482aef7a11d42672a8bc6daad
==========

[commit-bot: I haz the power, 2017-03-30 00:06:10]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/f8f69fd1d13eb65482aef7a11d42672a8bc6daad