Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1899)

Unified Diff: chrome/browser/ui/views/payments/payment_request_dialog_view.h

Issue 2779283002: [Web Payments] Implement the CVC Unmask dialog. (Closed)
Patch Set: Update AutofillPaymentInstrument's credit_card_ after unmasking. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_dialog_view.h
diff --git a/chrome/browser/ui/views/payments/payment_request_dialog_view.h b/chrome/browser/ui/views/payments/payment_request_dialog_view.h
index 8c1738e68cb69d0296b5dd317db34aae7e38c179..19c3f805c25ccdd8478fa4697a7570aa082b6c87 100644
--- a/chrome/browser/ui/views/payments/payment_request_dialog_view.h
+++ b/chrome/browser/ui/views/payments/payment_request_dialog_view.h
@@ -10,11 +10,14 @@
#include "base/macros.h"
#include "chrome/browser/ui/views/payments/view_stack.h"
+#include "components/autofill/core/browser/payments/full_card_request.h"
please use gerrit instead 2017/03/30 13:14:09 No need include this, because it's used only to im
anthonyvd 2017/03/30 15:43:41 Done.
#include "components/payments/content/payment_request_dialog.h"
#include "ui/views/window/dialog_delegate.h"
namespace payments {
+class CvcUnmaskUIDelegate;
+class CvcUnmaskViewController;
please use gerrit instead 2017/03/30 13:14:09 Can these two be made private? Then in the .cc fil
anthonyvd 2017/03/30 15:43:41 I'm not sure what you mean. I'm just forward decla
please use gerrit instead 2017/03/31 14:41:14 CvcUnmaskUIDelegate is used only as a private vari
anthonyvd 2017/04/04 13:25:22 Thanks for the details, this comment is now obsole
class PaymentRequest;
class PaymentRequestSheetController;
@@ -72,6 +75,8 @@ class PaymentRequestDialogView : public views::DialogDelegateView,
void ShowDialog() override;
void CloseDialog() override;
void ShowErrorMessage() override;
+ base::WeakPtr<autofill::payments::FullCardRequest::UIDelegate>
+ GetFullCardRequestUIDelegate() override;
void Pay();
void GoBack();
@@ -84,6 +89,9 @@ class PaymentRequestDialogView : public views::DialogDelegateView,
void ShowShippingAddressEditor();
void EditorViewUpdated();
+ void ShowCvcUnmaskSheet(
+ std::unique_ptr<CvcUnmaskViewController> view_controller);
+
ViewStack* view_stack_for_testing() { return &view_stack_; }
private:
@@ -109,6 +117,8 @@ class PaymentRequestDialogView : public views::DialogDelegateView,
// controller_map_.
bool being_closed_;
+ std::unique_ptr<CvcUnmaskUIDelegate> cvc_unmask_ui_delegate_;
+
DISALLOW_COPY_AND_ASSIGN(PaymentRequestDialogView);
};

Powered by Google App Engine
This is Rietveld 408576698