[Web Payments] Implement the CVC Unmask dialog.

chrome/browser/ui/views/payments/payment_request_dialog_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_H_
 
 #include <map>
 #include <memory>
 
 #include "base/macros.h"
 #include "chrome/browser/ui/views/payments/view_stack.h"
+#include "components/autofill/core/browser/payments/full_card_request.h"

[please use gerrit instead, 2017/03/30 13:14:09]

No need include this, because it's used only to implement the
PaymentRequestDialog's interface.

[anthonyvd, 2017/03/30 15:43:41]

Done.

 #include "components/payments/content/payment_request_dialog.h"
 #include "ui/views/window/dialog_delegate.h"
 
 namespace payments {
 
+class CvcUnmaskUIDelegate;
+class CvcUnmaskViewController;

[please use gerrit instead, 2017/03/30 13:14:09]

Can these two be made private? Then in the .cc file you would write something
like:

class PaymentRequestDilaogView::CardUnmaskUIDelegate {
 public:
  CardUnmaskUIDelegate() {}
  ~CardUnmaskUIDelegate() {}
  /// etc ...
};

[anthonyvd, 2017/03/30 15:43:41]

I'm not sure what you mean. I'm just forward declaring them because they're used
as pointers in function parameters below.

[please use gerrit instead, 2017/03/31 14:41:14]

CvcUnmaskUIDelegate is used only as a private variable and not used by anyone
else. Therefore, you can move this forward-declaration inside of the private:
section of PaymentRequestDialogView.

[anthonyvd, 2017/04/04 13:25:22]

Thanks for the details, this comment is now obsolete.

 class PaymentRequest;
 class PaymentRequestSheetController;
 
 // Maps views owned by PaymentRequestDialogView::view_stack_ to their
 // controller. PaymentRequestDialogView is responsible for listening for those
 // views being removed from the hierarchy and delete the associated controllers.
 using ControllerMap =
     std::map<views::View*, std::unique_ptr<PaymentRequestSheetController>>;
 
 // The dialog delegate that represents a desktop WebPayments dialog. This class
@@ skipping 33 matching lines @@
   ~PaymentRequestDialogView() override;
 
   // views::WidgetDelegate
   ui::ModalType GetModalType() const override;
 
   // views::DialogDelegate
   bool Cancel() override;
   bool ShouldShowCloseButton() const override;
   int GetDialogButtons() const override;
 
   // payments::PaymentRequestDialog

[please use gerrit instead, 2017/03/30 13:14:09]

No need to specify the "payments" namespace in this comment, because it's inside
of the "namespace payments {}" already.

[anthonyvd, 2017/03/30 15:43:41]

Done.

   void ShowDialog() override;
   void CloseDialog() override;
   void ShowErrorMessage() override;
+  base::WeakPtr<autofill::payments::FullCardRequest::UIDelegate>
+  GetFullCardRequestUIDelegate() override;
 
   void Pay();
   void GoBack();
   void ShowContactProfileSheet();
   void ShowOrderSummary();
   void ShowShippingProfileSheet();
   void ShowPaymentMethodSheet();
   void ShowShippingOptionSheet();
   void ShowCreditCardEditor();
   void ShowShippingAddressEditor();
   void EditorViewUpdated();
 
+  void ShowCvcUnmaskSheet(
+      std::unique_ptr<CvcUnmaskViewController> view_controller);
+
   ViewStack* view_stack_for_testing() { return &view_stack_; }
 
  private:
   void ShowInitialPaymentSheet();
 
   // views::View
   gfx::Size GetPreferredSize() const override;
   void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) override;
 
   // Non-owned reference to the PaymentRequest that initiated this dialog. Since
   // the PaymentRequest object always outlives this one, the pointer should
   // always be valid even though there is no direct ownership relationship
   // between the two.
   PaymentRequest* request_;
   ControllerMap controller_map_;
   ViewStack view_stack_;
 
   // May be null.
   ObserverForTest* observer_for_testing_;
 
   // Used when the dialog is being closed to avoid re-entrancy into the
   // controller_map_.
   bool being_closed_;
 
+  std::unique_ptr<CvcUnmaskUIDelegate> cvc_unmask_ui_delegate_;
+
   DISALLOW_COPY_AND_ASSIGN(PaymentRequestDialogView);
 };
 
 }  // namespace payments
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_H_