Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2779273004:
Test for IndexedDB crashing bug found by clusterfuzz. (Closed)
DescriptionTest for IndexedDB crashing bug found by clusterfuzz.
BUG=705837
Review-Url: https://codereview.chromium.org/2779273004
Cr-Commit-Position: refs/heads/master@{#461495}
Committed: https://chromium.googlesource.com/chromium/src/+/a812312f165c373e9f9fb684b229bb5a987e9328
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix typo. #
Total comments: 2
Patch Set 3 : Feedback. #Messages
Total messages: 22 (13 generated)
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
pwnall@chromium.org changed reviewers: + dmurph@chromium.org, jsbell@chromium.org
dmurph: Please check that I'm hitting the same case as the clusterfuzz repro. jsbell: Please review and see if this is a reasonable WPT test.
On 2017/03/29 20:52:31, pwnall wrote:
> dmurph: Please check that I'm hitting the same case as the clusterfuzz repro.
>
> jsbell: Please review and see if this is a reasonable WPT test.
Also worth noting: the first test failures on {linux,mac,win}_chromium_rel_ng
document the fact that the test actually catches the bug. I managed to get the
first try before the bugfix CL landed.
https://codereview.chromium.org/2779273004/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html (right): https://codereview.chromium.org/2779273004/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html:14: promise_test(testCase => { Do we really need this many cursors to get it to work?
https://codereview.chromium.org/2779273004/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html (right): https://codereview.chromium.org/2779273004/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html:14: promise_test(testCase => { On 2017/03/29 23:36:34, dmurph wrote: > Do we really need this many cursors to get it to work? Clusterfuzz used 10k (2x 5k). Also, this test intends to target all IDB implementations, so it shouldn't be aware of our (current) cursor limit.
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Huh. ok. Just didn't want to burn a ton of testing cpu for this to exercise something that required less. LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
test lgtm https://codereview.chromium.org/2779273004/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html (right): https://codereview.chromium.org/2779273004/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html:6: <link rel="help" href="http://crbug.com/705837"> I don't think this link makes sense for an upstreamed test.
Thank you very much for the feedback! https://codereview.chromium.org/2779273004/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html (right): https://codereview.chromium.org/2779273004/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/parallel-cursors-upgrade.html:6: <link rel="help" href="http://crbug.com/705837"> On 2017/04/03 16:18:03, jsbell wrote: > I don't think this link makes sense for an upstreamed test. Done.
The CQ bit was checked by pwnall@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org, dmurph@chromium.org Link to the patchset: https://codereview.chromium.org/2779273004/#ps40001 (title: "Feedback.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491242234817850,
"parent_rev": "b48b353161948224246626099272017cb9fbbb4f", "commit_rev":
"a812312f165c373e9f9fb684b229bb5a987e9328"}
Message was sent while issue was closed.
Description was changed from ========== Test for IndexedDB crashing bug found by clusterfuzz. BUG=705837 ========== to ========== Test for IndexedDB crashing bug found by clusterfuzz. BUG=705837 Review-Url: https://codereview.chromium.org/2779273004 Cr-Commit-Position: refs/heads/master@{#461495} Committed: https://chromium.googlesource.com/chromium/src/+/a812312f165c373e9f9fb684b229... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a812312f165c373e9f9fb684b229... |
