DevTools: Show top level event initiator when a child is selected.

DevTools: Show top level event initiator when a child is selected.

BUG=646928
Review-Url: https://codereview.chromium.org/2779253003
Cr-Commit-Position: refs/heads/master@{#461015}
Committed: https://chromium.googlesource.com/chromium/src/+/1459bd0dc4107bcde17077387bd5705097d51c44

[alph, 2017-03-29 21:22:17]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-03-29 22:08:20]

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
(right):

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:882:
if (!event || !initiator || !this._isVisible(initiator))
nit: first clause is redundant

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:569:
event[TimelineModel.TimelineModel._parentSymbol] = eventStack.peekLast();
should we stop pretending and do this in TracingModel?

[alph, 2017-03-29 22:16:57]

ptal

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
(right):

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:882:
if (!event || !initiator || !this._isVisible(initiator))
On 2017/03/29 22:08:20, caseq wrote:
> nit: first clause is redundant

Done.

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2779253003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:569:
event[TimelineModel.TimelineModel._parentSymbol] = eventStack.peekLast();
On 2017/03/29 22:08:20, caseq wrote:
> should we stop pretending and do this in TracingModel?

Can't do it on the TracingModel level, as we have timeline model events injected
(e.g. JSFrame) that are not present on the lower level.

[alph, 2017-03-30 21:16:24]

ptal

[caseq, 2017-03-30 22:44:51]

lgtm

https://codereview.chromium.org/2779253003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
(right):

https://codereview.chromium.org/2779253003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:147:
/** @type {!Array<!SDK.TracingModel.Event>} */
nit: should this keep an index instead?

[alph, 2017-03-30 23:32:17]

https://codereview.chromium.org/2779253003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
(right):

https://codereview.chromium.org/2779253003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:147:
/** @type {!Array<!SDK.TracingModel.Event>} */
On 2017/03/30 22:44:51, caseq wrote:
> nit: should this keep an index instead?

I tried that, but there seems to be a bit more code.

[alph, 2017-03-30 23:32:27]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:33:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 03:35:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490916747167750,
"parent_rev": "9dde8ce672f222dc77bd460ac703a2bef6910bc7", "commit_rev":
"1459bd0dc4107bcde17077387bd5705097d51c44"}

[commit-bot: I haz the power, 2017-03-31 03:36:20]

Description was changed from

==========
DevTools: Show top level event initiator when a child is selected.

BUG=646928
==========

to

==========
DevTools: Show top level event initiator when a child is selected.

BUG=646928

Review-Url: https://codereview.chromium.org/2779253003
Cr-Commit-Position: refs/heads/master@{#461015}
Committed:
https://chromium.googlesource.com/chromium/src/+/1459bd0dc4107bcde17077387bd5...
==========

[commit-bot: I haz the power, 2017-03-31 03:36:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1459bd0dc4107bcde17077387bd5...