Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2779243003: [Chromedriver] Reland of Add testcase for testing alert on new window. (Closed)

Created:
3 years, 8 months ago by gmanikpure
Modified:
3 years, 8 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Reland of Add testcase for testing alert on new window. And disable it for all desktop & android chrome until the issue is fixed. This is a reland of crrev.com/459971. BUG=chromedriver:833 Review-Url: https://codereview.chromium.org/1882603003 Cr-Commit-Position: refs/heads/master@{#459971} Committed: https://chromium.googlesource.com/chromium/src/+/1512539632abf713b55f5a16fe7b709fb1f4a57d patch from issue 1882603003 at patchset 40001 (http://crrev.com/1882603003#ps40001) Review-Url: https://codereview.chromium.org/2779243003 Cr-Commit-Position: refs/heads/master@{#460529} Committed: https://chromium.googlesource.com/chromium/src/+/9752d65b1a7b678630b51d29017e268aacafa647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 3 chunks +15 lines, -0 lines 0 comments Download
A chrome/test/data/chromedriver/alert_onload.html View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gmanikpure
Hi Sam, Please take a look. thanks.
3 years, 8 months ago (2017-03-29 17:03:06 UTC) #2
samuong
lgtm
3 years, 8 months ago (2017-03-29 17:31:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779243003/1
3 years, 8 months ago (2017-03-29 17:32:32 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:48:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9752d65b1a7b678630b51d29017e...

Powered by Google App Engine
This is Rietveld 408576698